Skip to content

fix: Include an error code in provider error events #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kinyoklion wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: Include an error code in provider error events #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/launchdarkly/openfeature/serverprovider/Provider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ private void handleDataSourceStatus(DataSourceStatusProvider.Status res, Complet
var message = res.getLastError() != null
? res.getLastError().toString()
: "the provider has encountered a permanent error or has been shutdown";
emitProviderError(ProviderEventDetails.builder().message(message).build());
emitProviderError(ProviderEventDetails.builder().message(message).errorCode(ErrorCode.GENERAL).build());
}
}
}
Expand Down
20 changes: 20 additions & 0 deletions src/test/java/com/launchdarkly/openfeature/serverprovider/LifeCycleTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import com.launchdarkly.sdk.server.subsystems.ComponentConfigurer;
import com.launchdarkly.sdk.server.subsystems.DataSource;
import com.launchdarkly.sdk.server.subsystems.DataSourceUpdateSink;
import dev.openfeature.sdk.ErrorCode;
import dev.openfeature.sdk.ImmutableContext;
import dev.openfeature.sdk.OpenFeatureAPI;
import dev.openfeature.sdk.ProviderEvent;
Expand Down Expand Up @@ -357,6 +358,25 @@ public void itIncludesTheDataSourceErrorInErrorEvents() throws Exception {
assertTrue(message.contains("bad"));
}

@Test
public void itIncludesAnErrorCodeInErrorEvents() throws Exception {
var config = new LDConfig.Builder()
.startWait(Duration.ZERO)
.dataSource(new DelayedDataSourceFactory(Duration.ofMillis(100), false, true))
.events(Components.noEvents())
.build();
var provider = new Provider("fake-key", config);
CompletableFuture<ErrorCode> errorCode = new CompletableFuture<>();

OpenFeatureAPI.getInstance().on(ProviderEvent.PROVIDER_ERROR, (detail) -> {
errorCode.complete(detail.getErrorCode());
});

OpenFeatureAPI.getInstance().setProviderAndWait(provider);

assertEquals(ErrorCode.GENERAL, errorCode.get(1000, TimeUnit.MILLISECONDS));
}

@Test
public void itIncludesHttpDataSourceErrorInErrorEvents() throws Exception {
var config = new LDConfig.Builder()
Expand Down
Loading