Repository navigation
docs: Note rejected SDK key retry in the initialization matrix row - #68
Draft
kinyoklion wants to merge 1 commit into
Draft
kinyoklion wants to merge 1 commit into
kinyoklion wants to merge 1 commit into
Conversation
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LaunchDarkly Python SDK 9.18.0 made a rejected SDK key retryable rather than permanently stopping the data source. The README says
start_wait=0waits "until the data source becomes valid or permanently fails", but a rejected key now never permanently fails. With zero,initializetherefore never completes while the key is rejected.start_waitparagraph gets the same note.Details
I checked this locally with
launchdarkly-server-sdk9.18.1 and an invalid key. The data source stayedINITIALIZING, andlast_errorreportedERROR_RESPONSE 401while it retried. It never reportedOFF.The provider allows
launchdarkly-server-sdk >=9.17.0,<10, so new installs get the retry behavior. #64 also edits these lines. Whichever merges second will need a small README conflict fix.Found in the weekly OpenFeature provider audit. Docs-only change.
Link to Devin session: https://app.devin.ai/sessions/c8bc4e80339b473882c2dddffe981edf
Open in Devin Desktop: https://app.devin.ai/desktop/session/c8bc4e80339b473882c2dddffe981edf?variant=devin
Requested by: @kinyoklion