fix: make integrations logos responsive on mobile - #8089
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe Honeycomb integration now selects hexagon sizes by viewport width. It calculates row capacity and grid height from the selected size. CSS dimensions, icon sizes, and small-screen padding use the responsive values. ChangesHoneycomb responsive layout
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix · Severity of issue fixed: Medium Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview deployment for PR #8089 removed. This PR preview was automatically pruned because we keep only the 3 most recently updated previews on GitHub Pages to stay within deployment size limits. If needed, push a new commit to this PR to generate a fresh preview. |
PARTH-TUSSLE
left a comment
There was a problem hiding this comment.
Hey @tanav29 , as the preview of your PR is pruned, could you pls add a preview (a screenshot or screen recording) so we could verify the changes visually ?
PARTH-TUSSLE
left a comment
There was a problem hiding this comment.
The changes in the ui is
Hey so thanks for adding the screenshots, so the fix actually works, the logos are now responsive, but I think we should follow the existing mesh kinda structure for them look here ->

And pls lmk if you find the structure already in your PR (the one that doesnt look like a mesh) being used anywhere else, if you find it then ig we can keep the current fix also or else I'd prefer that mesh structure. What do you say?
|
Yup i will get that mesh structure in mobile too |
|
The row-capacity calculation currently uses grid.offsetWidth, while the latest Integration.style.js adds 12px left/right padding to the ul on screens ≤540px. Since offsetWidth includes that padding, firstRow/secondRow can overestimate the number of hexagons that actually fit in the content area. |
|
setHoneycombHeight now subtracts the ul's computed horizontal padding (getComputedStyle(grid).paddingLeft/Right) from offsetWidth to get usableWidth, and uses that for firstRow/secondRow. This handles both the 12px mobile padding (≤540px) and the 50px desktop padding dynamically instead of hardcoding. |
I tested the preview in every viewport, it LGTM. |
Signed-off-by: Tanav Poswal <tanavposwal939@gmail.com>
Signed-off-by: Tanav Poswal <tanavposwal939@gmail.com>
Signed-off-by: Tanav Poswal <tanavposwal939@gmail.com>
9b9378b to
2a2f0e1
Compare
|
@PARTH-TUSSLE now i have signoff all the commits |
Thanks @tanav29 , LGTM 💯 |
|
@PARTH-TUSSLE @tanav29 Well, now that this has been merged, one thing seems to have been missed. On both mobile and desktop, there’s now a large gap between the bottom logos and the missing integration card. This increases the black empty space at the bottom, which doesn’t look right and should be fixed. |
Will check tomorrow if the issue persist will create a issue and a pr |








Description
This PR fixes #8083
Notes for Reviewers
Signed commits
Summary by CodeRabbit