Skip to content

fix(CustomCatalog): re-export sanitizeCatalogImageUrl from the package root #1852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mateusslezinsky wants to merge 1 commit into from
Closed

fix(CustomCatalog): re-export sanitizeCatalogImageUrl from the package root #1852

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,3 +164,11 @@ export {
type Team as TeamPickerRecord,
type TeamSearchFieldProps
} from './custom/DashboardWidgets/GettingStartedWidget/TeamSearchField';

// Same nested-barrel dts-drop quirk as FeedbackButton above: sanitizeCatalogImageUrl
// reaches the entry only through `export * from './custom'`, so rollup-plugin-dts
// drops it from the bundled d.ts and `import { sanitizeCatalogImageUrl } from
// "@sistent/sistent"` fails type-checking despite the runtime export. It lives in its
// own dependency-free leaf module (not `Helper.ts`, which imports the untyped
// `js-yaml` and would crash the dts build if the entry re-exported from it).
export { sanitizeCatalogImageUrl } from './custom/CustomCatalog/sanitizeCatalogImageUrl';
Loading