Repository navigation
Fixed SendDataOption in P031_SHT1X.ino - #5639
Merged
Merged
Conversation
This allows the device to be configured to send data as expected.
Member
|
Have you also checked other plugins to see if this was missing on those that actually generate data to be sent to a controller? A while ago, Ton optimized this code to have proper defaults in the struct so only those plugins that needed something other than the default would need to have such a line in the |
Contributor
Well, it looks like I accidentally removed that option, quite some time ago, though I really can't recall why that would have been necessary, so it's probably correct that it's restored 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed P031_SHT1X.ino to set SendDataOption to true since it was missing. This missing flag prevented the device configuration setting "Send to Controler" to be configured.
Now the device can be configured to send data as expected.