Correct error messages that do not name their code. - #1139
Merged
evoskuil merged 1 commit intoSep 20, 2026
Merged
Conversation
suspended_channel carries the message text of sacrificed_channel, so a channel stopped by store suspension renders identically to the routine download work redistribution. suspended_service renders as "sacrificed service" and validate10 as "validate0", neither of which is a code. The unit tests asserted the copied text and are updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three entries in the error message table do not name their code.
suspended_channelcarries the text ofsacrificed_channel, so a channel stopped by store suspension renders identically to the continuous download work redistribution;suspended_servicerenders as "sacrificed service", andvalidate10as "validate0", neither of which is a code.The messages now name their codes. The unit tests asserted the copied text and are updated with them.