Add NoneType check to class Entry

In class Entry

Lines 27 to 30 in 7b9219b

    
           def __init__(self, title=None, username=None, password=None, url=None, 
        
                        notes=None, otp=None, tags=None, expires=False, expiry_time=None, 
        
                        icon=None, autotype_sequence=None, autotype_enabled=True, autotype_window=None, 
        
                        element=None, kp=None):

title, username, password accept None as input.

pykeepass/pykeepass/entry.py

Lines 42 to 46 in 7b9219b

    
           self._element.append(E.String(E.Key('Title'), E.Value(title or ""))) 
        
           self._element.append(E.String(E.Key('UserName'), E.Value(username or ""))) 
        
           self._element.append( 
        
               E.String(E.Key('Password'), E.Value(password or "", Protected="True")) 
        
           )

But E.Value() reject None.
Since keepass allows entry with no title username or password,this will cause exception.

if title:
    self._element.append(E.String(E.Key('Title'), E.Value(title)))
if username:
    self._element.append(E.String(E.Key('UserName'), E.Value(username)))
if password:
    self._element.append(E.String(E.Key('Password'), E.Value(password, Protected="True")))

I think add NoneType check would be better.

What is the error you're seeing? The password or "" code handles None already:

>>> from pykeepass import PyKeePass; kp = PyKeePass('tests/test4.kdbx', 'password', 'tests/test4.key')

>>> e = kp.add_entry(kp.root_group, 'foobar', 'evidlo', None)

>>> e.password
''

Navigation Menu

Repository navigation

Add NoneType check to class Entry #435

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	def __init__(self, title=None, username=None, password=None, url=None,
	notes=None, otp=None, tags=None, expires=False, expiry_time=None,
	icon=None, autotype_sequence=None, autotype_enabled=True, autotype_window=None,
	element=None, kp=None):

	self._element.append(E.String(E.Key('Title'), E.Value(title or "")))
	self._element.append(E.String(E.Key('UserName'), E.Value(username or "")))
	self._element.append(
	E.String(E.Key('Password'), E.Value(password or "", Protected="True"))
	)

Add NoneType check to class Entry #435

Description

Activity

Evidlo commented on Aug 9, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions