Repository navigation
fix(native): mirror the loaded Pulls screens in their skeletons, and fix the Description heading in place - #1004
Merged
Conversation
…fix the Description heading in place The index skeleton draws rows of a loaded row's height with the checks column, filling the island. The pull request skeleton draws the title row with its buttons, the real tab strip and the open tab's layout: Overview, Commits, Checks, Conversation and Files each get their own, and the conversation and diff reads show them too instead of a line of text. Bars are measured off the text they stand for. On the Overview, the Description heading and its ⋯ span the column and stay put over a separator while the description scrolls under them. native/DESIGN.md spells out what a faithful skeleton is and records the fixed heading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pulls_list.go):skeletonRowisrowContentwith bars: the same insets (the row's vertical padding is nowpullsRowPadY, shared), number and title over the meta line, the checks chip inrowChecksWidth, the verdict and checkout columns reserved, a separator under each, as many rows as fill the island.pulls_skeleton.go,pulls_skeleton_tabs.go):skeletonText), the font's height centred in the text's line; a bar in aFlexedspans its room (spanning) so what follows lands at the row's end.pulls.pullsFiles.loadingis gone from every locale.th.Separator. On a narrow island it scrolls with the facts, as before.native/DESIGN.md: the Loading section spells out a faithful skeleton; a Fixed headings section records the separator.CHANGELOG.mdhas the entries.Test plan
native/: gofmt, vet and tests green.