Repository navigation
perf(native): record icon and arc paths once and keep them on the GPU - #1008
Merged
Merged
Conversation
Gio keys its path cache on where a path was recorded, and a path written into the frame's op.Ops is new every frame: every Lucide icon, ring and arc was re-stroked on the CPU, re-triangulated and re-uploaded 30 times a second while a session was busy. Icons now record their paths once per scale in an op.Ops of their own, and StrokeArc keeps a bounded record of the arcs it drew, so the renderer keeps their vertices between frames. Rig, dense window, one busy session, 30fps, 15s CPU profile: 1.61s to 0.79s, stroke.StrokePathCommands gone from the profile. GPU time per frame is unchanged: it is the painting itself, not the geometry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Gio keys its path cache on where a path was recorded (
ops.Keycarries theop.Opsand its version, bumped on everyReset). Text escapes this becausetext.Shaperrecords glyph outlines in anop.Opsof its own that is never reset. Everything lich recorded straight into the frame'sOpsdid not: every Lucide icon (icons.Icon.Layout), ring and arc (ui.StrokeArc) was re-stroked on the CPU, re-triangulated and re-uploaded withglBufferDataon every frame. With a session busy that is 30 times a second, and in the window's CPU profilestroke.StrokePathCommandsalone was 20% of the time.What
icons.Iconrecords its shapes' paths once per scale in anop.Opsit owns and hands the sameclip.PathSpecout on every frame, the way the shaper does for glyphs.LayoutFilledshares the record.ui.StrokeArckeeps a record of the arcs it drew, keyed by geometry. A turning arc is a new path every frame, so the record is bounded: past 1024 paths it starts over in a freshop.Ops, and the old one lives on while a frame still calls into it.Icons are package variables drawn from the window's goroutine; the records assume that.
Measured
Rig: nested headless compositor on an RTX 3050 Laptop, 1400x1420 window, 7 session cards, 3 busy rings, a project tab spinner and a terminal full of colored text, one busy session, 30fps. 15s CPU profile:
StrokePathCommandsGPU time per frame is unchanged, measured at 240Hz interleaving the two binaries: it is the painting itself (stencil passes, blit, swap), not the geometry, and it does not depend on what the window shows. Fewer or partial frames are the only lever on it; that is separate work.
Test plan
ui/icons:TestIconPathsAreRecordedOncePerScale, the same spec comes back at the same scale, another at another scaleui:TestStrokeArcPathsAreRecordedOnce, same arc same path, record starts over past its boundnative/: gofmt,go vet ./...,go test ./...