Build Services page: closing CTA section (LS-1598) - #56
Open
brandonmarshal wants to merge 4 commits into
Open
Conversation
- Rename patterns/section-cta.php (empty, unused stub) to
patterns/sections/services-cta.php, built out: "Let's scope it
properly." — eyebrow, heading, description, and a single button
reusing the exact "Request a systems review" button already
established in services-hero.php (same label, same link)
- Add src/scss/structural/corner-glow.scss: a shared, multi-consumer
two-corner gradient glow class (.ls-corner-glow) — colours and
opacities are CSS custom properties so future consumers can
override them inline instead of duplicating the file
- Wire into build/enqueue like the other sections (real
is_page('services') condition from the start)
Bug fix
- Corrected a Figma SVG gradient matrix decode error: the gradient's
base circle has r="10" (user-space units), scaled by the matrix's
76.861 — actual radius is 10 × 76.861, not 76.861 alone. Using the
scale factor alone produced blobs ~10x too small, reading as hard
circles instead of the intended soft, wide wash
- Set the CTA panel to a real 800px max width (contentSize, with
align:"wide" removed since it was overriding the constraint)
- Rename patterns/section-cta.php (empty, unused stub) to
patterns/sections/services-cta.php, built out: "Let's scope it
properly." — eyebrow, heading, description, and a single button
reusing the exact "Request a systems review" button already
established in services-hero.php (same label, same link)
- Add src/scss/structural/corner-glow.scss: a shared, multi-consumer
two-corner gradient glow class (.ls-corner-glow) — colours and
opacities are CSS custom properties so future consumers can
override them inline instead of duplicating the file
- Wire into build/enqueue like the other sections (real
is_page('services') condition from the start)
Bug fix
- Corrected a Figma SVG gradient matrix decode error: the gradient's
base circle has r="10" (user-space units), scaled by the matrix's
76.861 — actual radius is 10 × 76.861, not 76.861 alone. Using the
scale factor alone produced blobs ~10x too small, reading as hard
circles instead of the intended soft, wide wash
- Set the CTA panel to a real 800px max width (contentSize, with
align:"wide" removed since it was overriding the constraint)
brandonmarshal
added
area:theme
There was a problem hiding this comment.
🟡 Changes recommended
Two moderate issues remain, along with minor UK-English spelling nits.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds the closing Services CTA and reusable corner-glow styling, with frontend/editor asset wiring.
Changes:
- Adds the Services CTA pattern and removes the unused stub.
- Adds and compiles shared corner-glow CSS.
- Updates asset loading, build configuration, and changelog documentation.
File summaries
| File | Summary |
|---|---|
src/scss/structural/corner-glow.scss |
Adds reusable glow styling. |
patterns/sections/services-cta.php |
Adds the closing CTA pattern; icon dimensions and documentation spelling need updates. |
patterns/section-cta.php |
Removes the unused CTA stub. |
package.json |
Adds CSS build targets. |
inc/animations.php |
Adds conditional asset loading; reusable copies may load styling too late. |
functions.php |
Adds editor stylesheet loading. |
CHANGELOG.md |
Documents the changes; spelling nit remains. |
assets/css/corner-glow.css |
Compiled glow stylesheet. |
Review details
Files not reviewed (1)
- assets/css/corner-glow.css: Generated file
Suppressed comments (2)
patterns/sections/services-cta.php:29
- The
dimensionsobject is outsidestyle, unlike the workingcore/iconmarkup inservices-hero.php:114and the other Services sections. Core Icon dimensions are serialised understyle.dimensions; with this shape the8pxwidth is ignored and the dot renders at the default icon size. Movedimensionsintostyle.
<!-- wp:icon {"icon":"lightspeed/dot","className":"has-text-color","style":{"color":{"text":"var(--wp--custom--color--text--brand)"}},"dimensions":{"width":"8px"}} /-->
patterns/sections/services-cta.php:7
- This pattern description uses US spelling; please use “centred” to keep the repository's documentation in UK English.
* Description: The Services page's closing CTA: "Let's scope it properly." A centered eyebrow/
- Files reviewed: 7/8 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Bug fix - services-cta.php: fix wp:icon dimensions being a sibling of style instead of nested inside it — same bug class already fixed on PR #55, the eyebrow dot was rendering at the 24px default instead of 8px - inc/animations.php: load corner-glow.css unconditionally instead of gating it on is_page('services') — services-cta.php declares Inserter: true, so an editor can place it (and this shared class) on any page, where the condition would leave it caught only by the render_block/footer fallback. Same precedent as card-shells/ cta-buttons: cheap enough (~400 bytes) to load unconditionally Cleanup - Use UK-English spelling ("colour"/"colours", "centred") in prose documentation comments in services-cta.php and CHANGELOG.md, matching AGENTS.md's own established convention — CSS property names and values are unaffected, only English prose
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the Services page's closing CTA: "Let's scope it properly." This is the last of the 3 remaining content sections for LS-1598 — together with the sections in the earlier stacked PRs, the page's content is now complete.
Stacked on #55 — this branch is
feature/ls-1598-services-page-batch-4, based offfeature/ls-1598-services-page-batch-3.CTA pattern
patterns/section-cta.php(an empty, unused stub — no template or pattern anywhere referenced it) topatterns/sections/services-cta.php, built out fully: eyebrow, heading, description, and a single button./free-consultation/link already established inservices-hero.php, rather than introducing a new destination.contentSize, withalign:"wide"removed (it was overriding that constraint).Shared corner-glow background
src/scss/structural/corner-glow.scss: a shared, multi-consumer two-corner radial-gradient glow (.ls-corner-glow).color.gradientblock support only accepts a single gradient value, not layered gradients — same JSON limitation already documented insearch-hero.scss/work-hero.scss/blog-hero.scss.effect.hero.brand/effect.hero.cyan), so a future consumer overrides them inline rather than duplicating the file.inc/animations.phpwith a realis_page( 'services' )condition from the start (matching the same-session convention already applied to other Services bundles),package.json, andfunctions.php.Fixed
r="10"(user-space units), scaled by the transform's76.861— the actual radius is10 × 76.861, not76.861alone. Using the scale factor alone produced glow blobs roughly 10x too small, reading as small hard circles instead of the intended soft, wide wash. Corrected to87.5% 172.4%(from8.75% 17.24%), with the mistake documented directly in the file's own comment.Test plan
npm run schema:validate— all JSON files passnpm run patterns:escape— cleannpm run security:scan— cleanphp -lon the new pattern file — no syntax errorsvendor/bin/phpcs --standard=WordPresson the new pattern file andinc/animations.php— clean<head>Stacks on #55 (LS-1598).