Repository navigation
docs(sdk-less): add device_model to Android and iOS device data (LIN-3997) - #310
Merged
Merged
Conversation
…3997) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The SDK-less device data pages didn't match what the SDKs send. On Android, the device data page said
device_namecomes fromBuild.MODEL, while the quickstart (and the SDK) send"${Build.MANUFACTURER} ${Build.MODEL}". Neither platform documenteddevice_model, which is the field shown as Device Model on the dashboard. On iOS the backend uses onlydevice_modelfor Device Model (device_namecan be the name the user gave the phone), so an SDK-less iOS app following these pages got no Device Model at all. A customer (KoinBX) pointed out the Android mismatch.Linear: https://linear.app/linkrunner/issue/LIN-3997/koinbx-p588-device-model-is-empty-for-every-android-user-because-the
Description
device_model(Build.MODEL) to the field table, and splits the lookup list sodevice_namereads"${Build.MANUFACTURER} ${Build.MODEL}"anddevice_modelreadsBuild.MODEL, matching Android SDK 4.4.0 (DeviceInfoProvider.kt:110-111).device_model.device_model(theuname()hardware identifier, for exampleiPhone17,3, with theSIMULATOR_MODEL_IDENTIFIERfallback), matching iOS SDK 4.3.0.deviceModelIdentifier()helper and sendsdevice_model.🤖 Generated with Claude Code