Repository navigation
TPT add networking configuration for LKE clusters with VXLAN support - #1048
Merged
Merged
Conversation
vsilva-akamai
requested review from
mawilk90 and
zliang-akamai
and removed request for
a team
September 21, 2026 20:06
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Add IPv6 dual-stack request fields and comprehensive request-body serialization assertions.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds v4beta Enterprise LKE networking configuration, VXLAN support, and a networking retrieval endpoint.
Changes:
- Adds networking request/response types and create options.
- Adds
GetLKEClusterNetworking. - Adds fixtures and unit coverage.
| File | Summary |
|---|---|
test/unit/lke_clusters_test.go |
Tests networking serialization and response decoding. |
test/unit/fixtures/lke_cluster_networking_get.json |
Adds networking endpoint response fixture. |
test/unit/fixtures/lke_cluster_create.json |
Adds networking create response data. |
lke_clusters.go |
Adds networking models, options, and API endpoint. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
vsilva-akamai
changed the title
vsilva-akamai
force-pushed
the
nitro-networking
branch
from
September 21, 2026 20:41
e127ff3 to
efc846a
Compare
rpotla-akam
approved these changes
Sep 22, 2026
rpotla-akam
left a comment
rpotla-akam
left a comment
Contributor
There was a problem hiding this comment.
LGTM, please change the title appropriately :)
mawilk90
requested review from
a team and
jriddle-linode
and removed request for
a team
September 23, 2026 06:10
Comment on lines
+49
to
+55
| type LKEClusterNetworkingOptions struct { | ||
| RoutingMode *LKEClusterRoutingMode `json:"routing_mode,omitzero"` | ||
| ClusterCIDRIPv4 *string `json:"cluster_cidr_ipv4,omitzero"` | ||
| NodeCIDRMaskSizeIPv4 *int `json:"node_cidr_mask_size_ipv4,omitzero"` | ||
| ServiceClusterIPRangeIPv4 *string `json:"service_cluster_ip_range_ipv4,omitzero"` | ||
| MaxPods *int `json:"max_pods,omitzero"` | ||
| NodeBalancerBackendPrefixLength *int `json:"nodebalancer_backend_prefix_length,omitzero"` |
Member
There was a problem hiding this comment.
Is this only available for create LKE not update? If so can you name it as LKEClusterNetworkingCreateOptions
Contributor
Author
There was a problem hiding this comment.
Yes, it's create only. Updated the type name.
vsilva-akamai
force-pushed
the
nitro-networking
branch
from
October 6, 2026 10:15
893d0f4 to
273aea3
Compare
vsilva-akamai
changed the title
vsilva-akamai
force-pushed
the
nitro-networking
branch
from
October 15, 2026 09:49
273aea3 to
96c2fb7
Compare
zliang-akamai
approved these changes
Oct 15, 2026
ezilber-akamai
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
What does this PR do and why is this change necessary?
LKEClusterCreateOptions.GetLKEClusterNetworkingfor retrieving theeffective cluster networking configuration.
serialization and response decoding.
✔️ How to Test
What are the steps to reproduce the issue or verify the changes?
Deploy the matching v4beta LKE API, CAPI CRDs/webhooks/controller, and APINext
route/schema support before releasing this client. Create an Enterprise LKE
cluster with the new networking options and call
GetLKEClusterNetworking.Verify the request contains the expected routing-mode and CIDR fields and that
the response decodes the effective networking configuration. Cover IPv4 VXLAN
and dual-stack VXLAN when the matching server release is available.
How do I run the relevant unit/integration tests?
go test ./test/unit