Repository navigation
TPT-3596: Project CloudPulse Metrics Integration for Core Compute - #1058
Merged
Merged
Conversation
* linode alerts * add docs * address comments * address comments * update monthly transfer
* rm omitempty * use pointer * update unit test * misc * use omitzero * nit * add marshal empty test
* Create tests TestLinodeAlertsWorkflow, TestTryToUpdateLinodeAlertsLegacyAndAclpAtTheSameTime and update existing tests to verify alerts fields * Apply copilot suggestions * apply code review suggestions * apply code review suggestions * apply code review suggestions
# Conflicts: # instances.go # test/integration/instances_test.go # test/unit/fixtures/interface_list.json # test/unit/instance_test.go
yec-akamai
requested
a balanced review from Copilot
and removed request for
a team
October 12, 2026 14:51
yec-akamai
requested review from
ezilber-akamai and
mawilk90
and removed request for
a team
October 12, 2026 14:51
yec-akamai
changed the title
yec-akamai
changed the title
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The integration workflow uses DBaaS definitions, resets legacy thresholds, and leaks a cloned instance.
7 open findings
What changed in this PR
Adds CloudPulse alert associations to core compute instances.
Changes:
- Adds system/user alert IDs to instance models and options.
- Extends unit coverage and fixtures for alert serialization.
- Adds integration workflows for legacy and ACLP alerts.
| File | Description |
|---|---|
instances.go |
Adds alert IDs and create/clone options. |
test/unit/instance_test.go |
Tests alert decoding and serialization. |
test/unit/fixtures/instance_update.json |
Adds update alert response data. |
test/unit/fixtures/instance_get.json |
Adds get alert response data. |
test/unit/fixtures/instance_create.json |
Adds create alert response data. |
test/unit/fixtures/instance_clone.json |
Adds clone alert response data. |
test/integration/instances_test.go |
Adds alert integration workflows. |
test/integration/fixtures/TestInstance_UpdateACLPAlerts.yaml |
Records ACLP update workflow. |
test/integration/fixtures/TestInstance_LegacyAlertsWorkflow.yaml |
Records legacy alert workflow. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ezilber-akamai
approved these changes
Oct 12, 2026
ezilber-akamai
left a comment
ezilber-akamai
left a comment
Contributor
There was a problem hiding this comment.
Tests passing locally!
lgarber-akamai
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Merge project Cloud Pulse Metrics.
✔️ How to Test