Use lk agent dev instead of the deprecated Python dev command - #100
Open
omarelsaid wants to merge 1 commit into
Open
omarelsaid wants to merge 1 commit into
omarelsaid wants to merge 1 commit into
Conversation
Running `uv run python src/agent.py dev` now prints: dev mode is deprecated and will be removed in a future release; use lk agent dev instead Point the starter's development instructions at the LiveKit CLI so new users don't start from a deprecated command: - README.md: the "Run the agent" dev snippet - taskfile.yaml: the help output for the web console flow - taskfile.yaml: the `dev` task itself The console and production commands are unchanged, since only `dev` mode is deprecated. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Points the starter's development instructions at the LiveKit CLI, in three places:
README.md— the dev snippet under "Run the agent"taskfile.yaml— the help output printed by the web console flowtaskfile.yaml— thedevtask itselfWhy
Running the documented command emits two deprecation notices:
The second one matters most: hot-reload is gone from the Python CLI entirely, so
lk agent devisn't just a rename — it's now the only way to get reloading. As this is a starter template, the first command a new user runs shouldn't be a deprecated one that silently gives them less than the docs imply.Notes for reviewers
devmode is deprecated, so theconsoleandstartcommands in the README, theuv run ruff/uv run pytestinvocations, the Dockerfile, and the CI workflows are all untouched.{{ indent .INDENT "uv run" }} {{ .PYTHON_MAIN }} devbecame{{ indent .INDENT "lk agent dev" }}— the command is now a single literal, so.PYTHON_MAINis no longer interpolated at that line. It remains defined and in use byhelp_install_hint_if_neededand the console help line.git diff --checkclean,agent.py devno longer appears anywhere in the repo,lk agent devappears in exactly the three intended places, andtaskfile.yamlstill parses as valid YAML. I don't havetaskinstalled locally, sotask devitself hasn't been executed end to end.🤖 Generated with Claude Code