Conversation
The Python CLI's dev mode is deprecated and its in-process auto-reload has been removed, so `lk agent dev` is now the only way to get hot reload. Point the README, the taskfile help output, and the `dev` task at the LiveKit CLI for all three local modes, and move the CLI install instructions into Dev Setup so they come before the first command that needs them. The Dockerfile still starts the deployed agent with `uv run src/agent.py start`, since the container image doesn't include `lk`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01U7yszNU7t5aCHJsKLmU4hv
bcherry
changed the title
lk agent for console, dev, and start
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01U7yszNU7t5aCHJsKLmU4hv
|
Closed #100 in favour of this. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #100, which made the same move for
devonly. (That PR is from a fork this session can't push to, so the work landed here instead. Happy to close this in its favor if @omarelsaid wants to extend theirs.)What
Points the starter's local run instructions at the LiveKit CLI:
README.md—lk agent console,lk agent dev, andlk agent startunder "Run the agent", plus a new "Install the LiveKit CLI" step at the top of Dev Setup.taskfile.yaml— both post-init help hints and thedevtask.AGENTS.md— tells coding agents to run the agent through the CLI, and that the CLI's entrypoint detection expectssrc/agent.py.Why
Running the documented command emits two deprecation notices:
The second matters most: hot reload is gone from the Python CLI entirely, so
lk agent devisn't a rename — it's the only way to get reloading. #100 covereddev;consoleandstartare the documented commands too, and leaving them onuv runmeans the three modes in one README section are invoked three different ways.Separately, the CLI install instructions were buried in the "Using coding agents" section, below the first commands that need them — including
lk agent init, which the very next section recommends. They now lead Dev Setup, and the coding-agents section links down to them instead of repeating the platform commands.Notes for reviewers
uv run src/agent.py start. The container image doesn't includelk, and the README now says so.uvkeeps its role for dependencies (uv sync), linting, and tests. Only agent execution moved.connectmode has no CLI equivalent, so nothing here touches it.taskfile.yamlstill parses, noagent.py console|dev|startinvocation remains outside the Dockerfile.task devitself wasn't executed end to end —lkcan't be installed in this environment.lk agentfor console, dev, and start agent-starter-node#65 for the Node starter, plus a livekit/web docs change adding a CLI pointer to the pages that use these commands.🤖 Generated with Claude Code
https://claude.ai/code/session_01U7yszNU7t5aCHJsKLmU4hv