Repository navigation
test: freeze the clock in the transcription_delay anchor regression test - #7398
Merged
Merged
Conversation
The test read the wall clock twice with real work in between and asserted the difference within 0.1s. A scheduler stall on a loaded CI runner pushed the measured delay to 0.98s and failed an unrelated PR.
theomonnom
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
test_vad_anchor_survives_a_transcript_without_timestamps[stt]failed on an unrelated PR (#7390, run):The test read
time.time()at the top, let_on_stt_eventstamp_last_final_transcript_timewith a second live read, then asserted the two were 0.6s ± 0.1s apart. Any scheduler stall between the reads inflates the measured delay. That run's runner was under load (the log also shows the asyncio executor failing to join its threads within 300s), and the gap came out at 0.38s.Fix
Monkeypatch the clock in
audio_recognitionto return the samenowthe anchor was derived from, so the assertion is exact and independent of runner speed. The test still catches the original regression: a discarded VAD anchor would report a delay of 0.