Repository navigation
Fail pending RPCs when the room disconnects #1067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| --- | ||
| "client-sdk-android": patch | ||
| --- | ||
|
|
||
| `performRpc` now fails as soon as the room disconnects, rather than staying suspended until its response timeout. | ||
|
|
||
| Room cleanup reports every remote participant as disconnected, which already rejected calls addressed to a participant the room knew about. A call to an identity that never appeared in the participant list — an agent that has not joined yet, say — was in no such loop, so it stayed pending for the full `responseTimeout` after the room had gone. The caller's coroutine is now resumed with `RECIPIENT_DISCONNECTED` instead. | ||
|
|
||
| This matches the Rust SDK's `fail_all_pending` and the Swift SDK's `handleAllPendingDisconnected` (livekit/client-sdk-js#2251). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Disconnect can return a connection timeout
If an ack timer fires during
failAllPending, an unacknowledged RPC can returnCONNECTION_TIMEOUTafter disconnect begins. The timer still sees its ack after the sweep removes its response.Learn more
The RPC manager keeps separate maps for acknowledgments and responses. The ack timer removes an ack and completes the call with
CONNECTION_TIMEOUTwhen it finds one. DuringfailAllPending, the response map is cleared before the ack map, so the timer can win after the disconnect sweep has started. The later disconnect completion cannot replace the timeout error on the deferred result.Example: An unacknowledged call has an ack deadline at 7 seconds. At that deadline, disconnect copies and clears its response; the timer then removes its ack and completes
CONNECTION_TIMEOUT; the sweep'sRECIPIENT_DISCONNECTEDcompletion loses.Recommended fix: Clear both maps under their locks in a consistent lock order before invoking any
onResolvecallbacks. Ensure the ack timer cannot observe an ack whose response was already taken byfailAllPending.Was this helpful? React with 👍 or 👎 to provide feedback.