fix(api): preserve base URL paths in Twirp requests - #842
Draft
Kayvan-Zahiri wants to merge 1 commit into
Draft
Kayvan-Zahiri wants to merge 1 commit into
Kayvan-Zahiri wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
LiveKitAPIis given a URL such ashttps://example.com/proxy/livekit, API requests currently go to/twirp/...and drop/proxy/livekit. A proxy that routes the API under that path therefore returns 404. The request loop builds URLs from the origin, which intentionally excludes the path.Keep the normalized base path separately and include it when constructing each Twirp request, including retries. This also removes the extra slash inserted while reconstructing
self.host.Added local HTTP-server regressions covering HTTP and WebSocket-style URLs, empty and nested base paths, trailing slashes, and failover with default/custom Twirp prefixes. The failover tests also verify the request body and idempotency key stay the same across attempts.
Validation:
pytest tests/apiagainst the official LiveKit mock server bound to localhost: 46 passed (Python 3.12).git diff --check: pass.