Skip to content

fix: correct enviroment to environment in bot/scenes.ts - #883

Open
Jah-yee wants to merge 1 commit into
lnp2pBot:mainfrom
Jah-yee:fix/enviroment-to-environment
Open

Jah-yee wants to merge 1 commit into
lnp2pBot:mainfrom
Jah-yee:fix/enviroment-to-environment

Conversation

@Jah-yee

@Jah-yee Jah-yee commented Jul 31, 2026 •

Copy link
Copy Markdown

Corrects the typo 'Enviroment' to 'Environment' in error message.

Author: Jah-yee jydu_seven@outlook.com

Summary by CodeRabbit

  • Bug Fixes
    • Corrected a typo in an error message referring to an environment variable.

@coderabbitai

coderabbitai Bot commented Jul 31, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The change corrects a spelling error in the error message for the undefined HOLD_INVOICE_EXPIRATION_WINDOW environment variable.

Changes

Error message correction

Layer / File(s) Summary
Correct environment variable error text
bot/scenes.ts
The error message now uses “Environment” instead of “Enviroment”.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: grunch

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the typo correction in the error message and names the affected file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit found a typo in the night,
And made the error message right.
“Environment” now stands clear,
For HOLD_INVOICE_EXPIRATION_WINDOW here.
Hop, hop—clean text brings cheer!

Comment @coderabbitai help to get the list of available commands.

@Matobi98

Matobi98 commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Hey @Jah-yee, the fix looks good! One thing blocking the merge: the repo requires verified (GPG-signed) commits. Could you amend and force-push with a signed commit?

@Jah-yee
Jah-yee force-pushed the fix/enviroment-to-environment branch from 0270bf0 to 9c691d2 Compare October 22, 2026 15:44
@Jah-yee

Jah-yee commented Oct 22, 2026

Copy link
Copy Markdown
Author

Thanks for the heads-up about the signed-commit requirement — that was the only thing blocking the merge, and it is now fixed.

What I did:

  • Rebased the branch onto the current main (it was based on a commit from late July, so it had drifted quite far behind).

  • Re-created the single commit as a GPG-signed commit. GitHub now reports the signature as verified: true / reason valid for commit 9c691d2, signed with the 166608075+Jah-yee@users.noreply.github.com key.

  • The diff itself is unchanged and still exactly one line in bot/scenes.ts, inside the addInvoiceWizard scene where the error is thrown when HOLD_INVOICE_EXPIRATION_WINDOW is unset:

    • throw new Error('Enviroment variable HOLD_INVOICE_EXPIRATION_WINDOW not defined', ...)
    • throw new Error('Environment variable HOLD_INVOICE_EXPIRATION_WINDOW not defined', ...)

The branch still has exactly one commit and one changed file, and it now sits on top of the latest main (6d91a79).

Happy to rebase again if main moves in the meantime.

@Jah-yee

Jah-yee commented Oct 29, 2026

Copy link
Copy Markdown
Author

Hi Matobi98 — just checking in on the signed-commit requirement you raised back in August. As noted in my previous comment, the branch has been rebased onto current main and the single commit is now GPG-signed (verified: true, key 166608075+Jah-yee@users.noreply.github.com). The diff is unchanged — still exactly one line in bot/scenes.ts, correcting "Enviroment" to "Environment" in the HOLD_INVOICE_EXPIRATION_WINDOW error message. Let me know if there's anything else you'd like me to address before this can be merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants