Skip to content

fix(readnovelfull): throw on failed novel and chapter requests #2702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rajarsheechatterjee merged 2 commits into from
Oct 19, 2026
Merged

fix(readnovelfull): throw on failed novel and chapter requests #2702

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76f0d4d
fix(readnovelfull): throw on failed novel and chapter requests
RibatTRW Oct 17, 2026
22f3601
fix: Reconcile ReadNovelFull Template Version
rajarsheechatterjee Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion plugins/multisrc/readnovelfull/template.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export class ReadNovelFullPlugin implements Plugin.PluginBase {
this.icon = `multisrc/readnovelfull/${metadata.id.toLowerCase()}/icon.png`;
this.site = metadata.sourceSite;
const versionIncrements = metadata.options?.versionIncrements || 0;
this.version = `2.3.${1 + versionIncrements}`;
this.version = `2.3.${2 + versionIncrements}`;
this.options = metadata.options;
this.filters = metadata.filters;
if (this.options?.imageReferer) {
Expand Down Expand Up @@ -396,6 +396,13 @@ export class ReadNovelFullPlugin implements Plugin.PluginBase {
async parseNovel(novelPath: string): Promise<Plugin.SourceNovel> {
const url = this.site + novelPath;
const result = await fetchApi(url);
if (!result.ok) {
throw new Error(
result.status === 404
? 'Novel not found (404), it may have been removed from this source.'
: `Could not reach site (${result.status}: ${result.statusText}) try to open in webview.`,
);
}
const body = await result.text();

const novel: Partial<Plugin.SourceNovel> = {
Expand Down Expand Up @@ -782,6 +789,13 @@ export class ReadNovelFullPlugin implements Plugin.PluginBase {

async parseChapter(chapterPath: string): Promise<string> {
const response = await fetchApi(this.site + chapterPath);
if (!response.ok) {
throw new Error(
response.status === 404
? 'Chapter not found (404), it may have been removed from this source.'
: `Could not reach site (${response.status}: ${response.statusText}) try to open in webview.`,
);
}
let html = await response.text();
if (this.options?.customJs) {
try {
Expand Down
Loading