Repository navigation
Conversation
📊 cpp-sdk doc-test reportThe real accounts module, run through a logoscore daemon with the whole stack built against this commit of the C++ SDK — rendered alongside the commands actually run and their output (updated each run, commit Pages can take a minute to update after the run finishes. |
This was referenced Sep 25, 2026
Draft
feat!: Basecamp is always its shell; no token mirror, no "core" fallback
logos-co/logos-basecamp#437
Draft
liblogos drops its lifecycle C API and the token listener, so LogosCore stops falling back to them: - shellName is required, and start() throws when no shell binding comes back: liblogos then has no token authority and loads nothing. - Every lifecycle call and query goes through core_service. The queries that were C-only map onto its new read methods: getModuleDependencies, getModuleDependents, getModuleOptionalDependencies, getModulesInfo and getOptionalLoadReport, now in core_service.lidl. - tokenListener and token() are gone; processModule stays on the C API. - logos::host::tokenKeys goes with the protocol's token registry. Tests answer each core_service method from a stub binding. Relocks logos-protocol onto the token-registry retirement. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A module that still calls it (capability_module on master, until its registry mode goes) must keep compiling against this SDK, or the SDK's doc-tests, which build master modules, fail. On protocol 0.13 it answers empty with an ungranted status. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dlipicar
force-pushed
the
feat/core-service-client
branch
from
October 3, 2026 12:47
5e3245d to
18c224c
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dlipicar
force-pushed
the
feat/drop-legacy-mode
branch
from
October 3, 2026 12:47
b389bd4 to
0dc0adc
Compare
…; this branch's flake.lock stands) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #169. Part of the runtime-control wave's cleanup. It deletes legacy mode, the token listener, and liblogos' deprecated lifecycle C API (
load_module,unload_module,refresh_modules, theget_*queries,get_module_stats,optional_load_report,get_token,set_token_listener). Every consumer migrates to core_service through the shell binding.logos::host::LogosCoreshellNameis required. Construction throws without one, before anything is initialised.start()throws when no shell binding comes back. That means liblogos has no token authority (capability_module isn't bundled or didn't run in-process), and nothing would load.Every lifecycle call and query goes through core_service, with no C API fallback. The ones that were C-only now map onto core_service's new read methods, added to
core_service.lidl. Each answers the JSON the C function did:dependenciesgetModuleDependenciesdependentsgetModuleDependentsoptionalDependenciesgetModuleOptionalDependenciesmodulesInfoJsongetModulesInfooptionalLoadReportJsongetOptionalLoadReportBefore
start(), calls return false or empty; nothing is dialled.Removed:
Config::tokenListener,token(), and the C declarations of every removed function.processModulestays on the C API: it's the embedder's alone.Other changes
logos::host::tokenKeysstays as a retired shim (feat(tokens): retire the token registry logos-protocol#98 retires the registry): on protocol 0.13 it answers empty with an ungranted status, and a module that still calls it (capability_module on master) keeps compiling. The cdylib generator's emitted comments no longer describe the registry carve-out.test_logos_host_core.cppanswers each core_service method from a stub binding. It asserts:start()throwing without a binding;start().logos-protocolmoves onto feat(tokens): retire the token registry logos-protocol#98.🤖 Generated with Claude Code