Repository navigation
Conversation
…der CI lint The docstring baseline comments claimed two things that are not true, both corrected against measured behaviour: - per-file-ignores is a union of every matching pattern, not a most-specific match. A rule listed for a file is ignored for that file, so new violations of an already-baselined rule are also ignored. Removing a rule from a narrow tier is a no-op while a wider tier still lists it, which made the ratchet inoperative for four of the eight tiers. - The baseline count is 665 findings under the committed google convention (507 inside the CI lint scope), not 864; 864 is the default pep257 count. The google convention is also what suppresses the D203/D211 and D212/D213 warnings, so the config emits none. Extend the lint scope from `photoshop` to `photoshop test scripts`. The baseline declares tiers for test/ that no CI job could reach, so they were dead configuration; scripts/ was outside every gate. Reformat the six test files that ruff format reports, which is what the repo's own pre-commit hook already applies. All six are AST-identical before and after. Wire `generate_llms.py --check` into the same job so drifted llms.txt files fail the build instead of only producing a bot pull request. Also correct the generator docstring, which pointed at a workflow file that does not exist, and the version comment: the stamped version is the last released one, because the job runs before release-please creates the tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scratch PR: llms.txt is deliberately drifted to confirm the new --check step turns the build red. Not for merge.