Repository navigation
Add an option to turn off the unused-driver selection warning - #474
Merged
Merged
Conversation
Issue lostindark#472 asks for a way to stop the "Select Unused Driver(s)" confirmation dialog from showing every time. Add "Warn Before Selecting Unused Drivers" under Options, on by default and saved like the other options. When it is off the selection happens straight away; the yellow review reminder in the status bar is still shown. The menu text is translated for all 21 locales. Because it has no generated Language property, the item is created in code after InitializeComponent(). That same setup now also restores the "Include Boot Critical in Old Drivers" check mark after switching language, which was previously lost. Fixes lostindark#472
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #472.
This adds a "Warn Before Selecting Unused Drivers" item under Options, next to "Include Boot Critical in Old Drivers". It's on by default, so nothing changes unless you turn it off. When it's off, "Select Unused Driver(s)" selects the drivers right away without the dialog. The yellow reminder in the status bar is still shown either way, so there's still a nudge to review the selection and back up first.
I went with an Options item rather than a "Don't show again" checkbox in the dialog, because FlexibleMessageBox doesn't support a checkbox. It also matches how the boot-critical option already works, and it's easy to turn back on.
A few notes:
Language.ResourceManager.GetString(...)instead of a generated property. Because of that, the menu item is created in code right afterInitializeComponent()instead of in the designer.DSEFormTeststhat checks both the button and the context menu select the drivers without asking when the option is off.