Repository navigation
Truncate the date properties to the day so the columns sort as they display - #478
Merged
Merged
Conversation
…display
The Date and Install Date columns format with Language.Date_Format, which is {0:d},
and grouping already used InstallDate?.Date, but both properties kept the full
timestamp that DEVPKEY_DriverPackage_DriverDate and _ImportDate report. ObjectListView
sorts the raw value, so two entries sharing a day never compared equal and
Shift-clicking a second column did nothing for them.
Closes lostindark#460
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Date and Install Date columns format their values with
Language.Date_Format, which is{0:d}, and grouping inDSEFormalready usedInstallDate?.Date. Both properties kept the full timestamp thatDEVPKEY_DriverPackage_DriverDateandDEVPKEY_DriverPackage_ImportDatereport, andObjectListViewsorts the raw value.Two entries from the same day at 08:15 and 23:45 therefore never compared equal, so Shift-clicking a second sort column changed nothing for anything sharing a day. That is the case in the issue.
DriverDateandInstallDatenow truncate to the day on assignment. No consumer wanted the time: both columns use the format string, grouping uses.Dateand the CSV export uses"d".New test
RaprTests/DriverStoreEntryTests.cscovers both properties, includingSetDriverDateAndVersion, and asserts that a same-day tie keeps the orderObjectListViewhands to the secondary column.Closes #460