fix(crypto): restore rendered example - #1840
Open
SoYuCry wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How I found this
I noticed that the Crypto section on the Metrics Embed GitHub Marketplace page did not display anything when expanding Render example.
Cause
The Crypto plugin metadata still referenced a
via.placeholder.complaceholder instead of a generated example. That placeholder is no longer available. In addition, the Crypto example hadprod.skip: true, so the examples workflow never generatedmetrics.plugin.crypto.svgon theexamplesbranch.Solution
prod.skip.metrics.plugin.crypto.svgon theexamplesbranch, consistently with the other plugins.Once merged, the repository build workflow will regenerate the derived README and examples workflow files, and the examples workflow can publish the SVG used by the Marketplace preview.
Verification
npm run buildnpm run test-contrib(26 tests passed)