Skip to content

fix(crypto): restore rendered example - #1840

Open
SoYuCry wants to merge 1 commit into
lowlighter:masterfrom
SoYuCry:fix/crypto-render-example
Open

fix(crypto): restore rendered example#1840
SoYuCry wants to merge 1 commit into
lowlighter:masterfrom
SoYuCry:fix/crypto-render-example

Conversation

@SoYuCry

@SoYuCry SoYuCry commented Aug 26, 2026

Copy link
Copy Markdown

How I found this

I noticed that the Crypto section on the Metrics Embed GitHub Marketplace page did not display anything when expanding Render example.

Cause

The Crypto plugin metadata still referenced a via.placeholder.com placeholder instead of a generated example. That placeholder is no longer available. In addition, the Crypto example had prod.skip: true, so the examples workflow never generated metrics.plugin.crypto.svg on the examples branch.

Solution

  • Enable the Crypto example in the production examples workflow by removing prod.skip.
  • Point the Crypto preview metadata to metrics.plugin.crypto.svg on the examples branch, consistently with the other plugins.
  • Keep the test example skipped so regular tests do not depend on the external CoinGecko API.

Once merged, the repository build workflow will regenerate the derived README and examples workflow files, and the examples workflow can publish the SVG used by the Marketplace preview.

Verification

  • npm run build
  • npm run test-contrib (26 tests passed)
  • Confirmed the CoinGecko coin and market chart endpoints used by the plugin return HTTP 200.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant