Repository navigation
feat(interrogate): add a cost lens, sharpen exposure, completeness and parity, and gate review fixes - #24
Merged
Conversation
…d parity; gate review fixes that add logic
…p older leaks non-blocking Gate findings (Opus, Sonnet) on f74f93c: - The review-fix gate sat in Babysit step 8, between "unless the owning PR has merged" and "In that case", so it redirected every fix to a follow-up PR; it also had no scope, no rules for its findings, no round cap, and an exemption for rewrites of the cited lines (the very fix that let the quadratic scan through). It moves to bugbot-triage.md's `fix` rule, which every review-fix route uses, with a diff scope, Opening a PR step 2's rules, and one more pass at most. Babysit returns to main's text. - Cost probes now start small, grow fourfold, and stop at a per-run timeout; at 10,000 characters an exponential regex never returns. - An older path that leaks the same way is reported as a non-blocking follow-up, not a finding that blocks the PR. - translation.md no longer says upstream gates before the PR opens.
…ow-ups an output slot Gate round 2 (Opus, Sonnet) on 1331ac5, both raising the same set: - The "one-line value change" exemption let a one-character regex fix through. Any behavior change is gated now, and a one-character regex, limit or size change explicitly counts. - The gate imported Opening a PR step 2's rules, whose blocker means "stay a draft" and whose second round re-imports the cited-lines exemption. The triage rule now states its own: one more pass whatever lines the fixes touch, never a third, and a finding you won't fix holds the push and goes to the user. - Fixes for a person's comment skipped the gate. Babysit step 8 and the multi-phase fix-round rule now point every review fix at it. - An older path's leak had nowhere to go. interrogate's brief, Verify and Output gain non-blocking Follow-ups; Opening a PR step 5 lists them. - translation.md now says upstream lacks interrogate in triage, Babysit and fix rounds, not everywhere. Tested: bun scripts/check-port.ts (0 findings). No third gate round, per Opening a PR step 2; each finding was checked against the final text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The pre-PR gate should catch what review bots keep catching. On PostHog/posthog-python#1226 it didn't: after our gate passed, reviewers found six more bugs across five rounds. Those were a broken older supported dependency version, secrets in captured stack-frame source lines, a spec's JSON-member redaction rule not implemented, a background task keeping a traceback alive, an exponential regex, and a quadratic scan on
\"runs. #22 and #23's lenses were installed and in the brief the whole time. Two things went wrong:What changed
blind-spots.mdgains a Cost lens: hostile-input time, grown from small sizes with a per-run timeout, near-match and escape-sequence probes for backtracking regex engines, and memory a long-lived holder keeps alive.bugbot-triage.md'sfixrule runs interrogate on every behavior-changing review fix before it's pushed. A one-character regex or limit change counts. It allows one more pass on the fixes for its findings and never a third, and a finding you won't fix holds that push and goes to the user. Babysit step 8 and the multi-phase fix-round rule point every review fix at it, a person's comment included.translation.mdrecords the fork-only departures.Verification
Replay. Sonnet adversaries got the same brief on the posthog-python commits where reviewers later found bugs. The only thing that changed between runs was the lens file.
mainlenses8bbd1fb(first gate head)8bbd1fb8bbd1fb8bbd1fbd8a7a559c1cb4f\"runsd8a7a55, where it already existed)The new-lens runs also found an unreported gap: object keys skip the JSON-member pass. They each reproduced the bug against the real code, with timings, before/after event dumps, or failing calls.
Gate. Two rounds of Opus and Sonnet adversaries.
translation.mdcontradicting itself. All of these are fixed in1331ac5.5cbc168.bun scripts/check-port.tsreports 0 findings.Blast radius