Skip to content

fix: fail on ambiguous entity names instead of taking the first - #307

Merged
lucassabreu merged 5 commits into
lucassabreu:mainfrom
nikosavola:nikosavola/push-lpnxoltukkkt
Sep 21, 2026
Merged

lucassabreu merged 5 commits into
lucassabreu:mainfrom
nikosavola:nikosavola/push-lpnxoltukkkt

Conversation

@nikosavola

Copy link
Copy Markdown
Contributor

A name matching several projects or tasks silently resolved to whichever the API listed first, so writes could hit the wrong entity.

@codecov

codecov Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 38.75969% with 79 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.14%. Comparing base (65a7104) to head (7f64a86).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/mocks/mock_Client.go 0.00% 44 Missing ⚠️
internal/mocks/mock_Config.go 0.00% 17 Missing ⚠️
internal/mocks/mock_Factory.go 0.00% 6 Missing ⚠️
pkg/cmd/time-entry/util/interactive.go 0.00% 6 Missing ⚠️
pkg/search/find.go 86.66% 4 Missing ⚠️
pkg/search/errors.go 89.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #307      +/-   ##
==========================================
+ Coverage   32.86%   33.14%   +0.28%     
==========================================
  Files         141      141              
  Lines        9020     9089      +69     
==========================================
+ Hits         2964     3013      +49     
- Misses       5932     5952      +20     
  Partials      124      124              
Flag Coverage Δ
unittests 33.14% <38.75%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread pkg/search/errors.go Outdated
- a name matching several projects or tasks silently resolved to whichever
  the api listed first, so writes could hit the wrong entity

Co-Authored-By: DeepSeek V4.1 <noreply@deepseek.com>
@nikosavola
nikosavola force-pushed the nikosavola/push-lpnxoltukkkt branch from 4555393 to 87d166e Compare September 18, 2026 06:19
Comment thread strhlp/strhlp.go Outdated
Comment thread strhlp/strhlp_test.go Outdated
Comment thread CHANGELOG.md Outdated
Co-authored-by: Lucas dos Santos Abreu <lucas.s.abreu@gmail.com>
Comment thread strhlp/strhlp.go Outdated
@lucassabreu
lucassabreu enabled auto-merge (squash) September 21, 2026 13:13
@lucassabreu
lucassabreu enabled auto-merge (squash) September 21, 2026 13:13
@lucassabreu
lucassabreu merged commit 17fa823 into lucassabreu:main Sep 21, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants