Skip to content

fix: defer Google marker add until custom view lays out - #96

Merged
lodev09 merged 2 commits into
mainfrom
fix/google-marker-default-pin-flash
Sep 28, 2026
Merged

lodev09 merged 2 commits into
mainfrom
fix/google-marker-default-pin-flash

Conversation

@lodev09

@lodev09 lodev09 commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Custom-view markers on Google Maps briefly showed the SDK default pin before the rasterized icon appeared.

  • iOS: addMarkerViewToMap skips creating the GMSAdvancedMarker until layoutSubviews has run; markerViewDidLayout re-syncs and adds it with the correct icon.
  • Android: processPendingMarkers now skips custom-view markers that haven't laid out, matching the existing guard in syncMarkerView; markerViewDidLayout adds them via updateIcon.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Test Plan

  • Mount custom-view markers (rasterized and non-rasterized) on Google Maps, confirm no default pin flash
  • Mount markers before the map is ready, confirm pending markers still appear
  • Remove markers before layout, confirm no crash

Screenshots / Videos

N/A

Checklist

  • I tested on iOS
  • I tested on Android
  • I tested on Web
  • I updated the documentation (if needed)

@vercel

vercel Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
lugg-maps Ready Ready Preview Sep 28, 2026 6:54pm UTC

Request Review

@lodev09 lodev09 changed the title fix(ios): defer Google marker add until custom view lays out fix: defer Google marker add until custom view lays out Sep 28, 2026
@lodev09
lodev09 merged commit 1cfc856 into main Sep 28, 2026
5 checks passed
@lodev09
lodev09 deleted the fix/google-marker-default-pin-flash branch September 28, 2026 18:56

This branch was successfully deployed

1 active deployment
Preview — 92ea99db Deployed Sep 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant