Repository navigation
Remove the empty _check_boardtype() - #398
Merged
Merged
Conversation
The last board checks it held (ESP32-P4) moved into the M5GFX board detector, leaving a private function that returned its argument on every target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #397. Remove the private
_check_boardtype(): its last board checks (ESP32-P4) moved into the M5GFX board detector, leaving a function that returned its argument on every target.Changes
_check_boardtype()and its call inbegin(). The board is now chosen in this order: the detector's result,cfg.fallback_board,BOARD_ID(P4), the detector's candidate, then the package default.Tested