Repository navigation
begin(): external displays follow cfg.clear_display - #416
Merged
Merged
Conversation
Module Display, Unit OLED / MiniOLED / GLASS / GLASS2 / LCD, Module RCA and Unit RCA were initialized with init() regardless of cfg.clear_display, so they were reset and cleared even when the sketch asked to keep the display (m5stack/M5GFX#370). They now follow the flag like the internal display and Unit PoE-P4: init() when it is true, init_without_reset(false) otherwise. The default is unchanged.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs m5stack/M5GFX#370.
Problem
begin()initialized the external displays (Module Display, Unit OLED / MiniOLED / GLASS / GLASS2 / LCD, Module RCA, Unit RCA) withinit()regardless ofcfg.clear_display, so they were reset and cleared even when the sketch asked to keep the display. The internal display and Unit PoE-P4 (display out) already followed the flag.Change
The eight external displays are initialized the same way as the internal one:
init()whencfg.clear_displayis true,init_without_reset(false)otherwise. The default (clear_display = true) is unchanged.The panel side of #370 (EPD and LED panels wiping the image during init, and the host buffer of the OLED / GLASS units being cleared in
init()so that this path does not send an uninitialized buffer) is m5stack/M5GFX#375; this change needs that one. Atom Display still usesinit_without_reset()unconditionally (it does not clear even withclear_display = true); unchanged here.Test