Repository navigation
test: ring-list shape tests moved in from macTEM - #38
Merged
Merged
Conversation
Four tests an app held on the kit's ring lists, which the kit's own tests did not cover: the metric family and Laue class of cells near a higher symmetry, the six-parameter lattice recognition edges, the ring counts of tetragonal and orthorhombic cells with the Z = 104 refusal, and the monoclinic cell whose a<->c swap is a true symmetry (83 rings, 28 named by several orbits, 698 reflections). No number changed. Done: RingListShapeTests in DiffractoScatteringTests. Next: the app drops its copies once this lands. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Paul · project thread
Part of mac4DSTEM/macEM-suite#79 (the macTEM side removes its copies).
macTEM held five test files that test only this kit's API. For each test I checked whether the kit already runs it (most were ported at the kit split, under the same or a
reference …-annotated name). Four were not covered, and move here asTests/DiffractoScatteringTests/RingListShapeTests.swift, in Swift Testing:metricToleranceKeepsNearCubicAndNearHexagonalCells: Laue class, metric family and ring count of cells 1e-11 to 1e-6 off cubic or hexagonal.latticeRecognition: the six-parameter edges (beta 90 + 1e-10 orthorhombic, + 1e-8 monoclinic; alpha or gamma 1e-8 off triclinic; unique axes a and c).lowerSymmetryCellsHaveRingsAndAnUnsupportedElementIsRefused: tetragonal 58 rings, orthorhombic 74, near-cubic 15, Z = 104 refused.swapEquivalentReflectionsAreOneOrbitAndCoincidencesStayNamedByTheirOrbits: a = c, cos beta = -1/4 is mmm; 83 rings, 28 multi-orbit,{2 0 0} + {2 0 -1}, 698 reflections.Already covered here, so not moved:
testFamilyIntensityIsTheSumOverMembers(structure-factor pins),testFirstThatAppliesPairs(testVerdictOrderandScatteringTruthTests.testRefusals),testOrbitSizesAndMultiplicity(RingIndexingTests), and every test ofRingCalibrationTests,RingFitCalibrationTestsandEllipseNoisyRingTests(same names in DiffractoGeometryTests).Test-only: no number, API or fixture changes, so no CHANGELOG line beyond this title.
swift test -c release --parallel --skip DiffractoKitParityTests: green,RingListShapeTests4 of 4.🤖 Generated with Claude Code