Repository navigation
docs: name what tests, parity rows and pin scripts hold - #41
Merged
Merged
Conversation
…k session made them FastDetectionTests: the decoder Slice2 is now StructureFactorPins and slice2Presets is now scatteringPresets. ConventionalSymmetryTests: the test testConventionalFalseIsSliceOnesDetection... is now testConventionalFalseIsThePlainDetectionAndConventionalFilesAreUnchanged, and a comment says the source == "slice-1" filter is the label the conventional cell pins give the CIF fixture structures. The filter string is fixture data and stays. docs/parity.md P12, P13 and the py4DSTEM note name the fixtures and the ring rule, not the session. The first docstring line of seven tools/pins scripts names the module it pins. No test meaning and no fixture byte changes. FastDetectionTests and ConventionalSymmetryTests pass (13 tests). Done: part of #40. Next: the CIF headers (a fixture move, pins regenerated) and the remaining tools/pins comments. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Paul · project thread
Part of #40
This PR changes names and comments only. No test meaning changes and no fixture bytes change.
Done here
Slice2is nowStructureFactorPins, andslice2Presetsis nowscatteringPresets.testConventionalFalseIsThePlainDetectionAndConventionalFilesAreUnchanged. A comment explains thesource == "slice-1"filter: it is the label the conventional-cell pins give the CIF fixture structures. The string itself is fixture data, so it stays.Left open on #40
pymatgen-cells-pins.jsonandnumpy-structure-factor-pins.json, so changing a header is a fixture move. It needs its own commit, regenerated pins and a CHANGELOG line."source": "slice-1","purpose","families") wait for a regeneration.Test evidence
swift test -c release -j 1 --skip DiffractoKitParityTests --filter "FastDetectionTests|ConventionalSymmetryTests": 13 tests in 2 suites passed. CI runs the full unit gate.🤖 Generated with Claude Code