Repository navigation
docs: last README, CITATION and fixture provenance gaps - #56
Merged
Merged
Conversation
The two structure-factor presets ported from macTEM cited commit a58c84c, which is not in the public macTEM history. The pin script and the note strings it writes into numpy-structure-factor-pins.json now say "macTEM before v1.0.0 (history squashed)", as NOTICE does. Only the two note strings move; no number changes and the file is not hash-locked by another pin. Tests/Fixtures/README.md lists orix-orientation-api-pins.json and counts 54 files. CITATION.cff dates 0.11.0 with its release day, 2026-10-30. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Paul · project thread
Fixes #17
#28 and #39 did most of this issue. This PR closes the gaps left on
main:tools/pins/structure-factors/pins.pystill cited macTEMa58c84c, and the script writes that text into thenoteof two structures innumpy-structure-factor-pins.json. Both now say "macTEM before v1.0.0 (history squashed)", asNOTICEdoes. A fixture move of two note strings only: no number changes, and no other pin hash-locks this file. No other file citesa58c84cor9482831.Tests/Fixtures/README.mdlistsorix-orientation-api-pins.json(added by feat: Orientation from Euler angles, dot, dotOuter and distanceMatrix #44) and counts 54 tracked files, which is whatgit ls-filesgives. The stray.keepis already gone.date-releasedwas still 0.10.0's date (2026-10-22) underversion: 0.11.0; it is now 2026-10-30, the 0.11.0 release day. From the next release on, release-please writes it (ci: release-please dates CITATION.cff in the Release PR #45).Bullets already done on
mainor settled elsewhere:Left for Paul: the Swift Package Index listing (submitting the package to swiftpackageindex.com). The README badge follows once the package is listed.
Test evidence:
swift test -c release --skip DiffractoKitParityTestsgreen locally (0 failures). CI pending.🤖 Generated with Claude Code