Repository navigation
test: the CSV export pins carry the sentences the application writes today - #56
Merged
Merged
Conversation
…today csv-export-pins.json held the radial-profile and spots validation sentences and the lineage sentence as the application wrote them when the pins were made, with internal milestone ids in them. The application has since dropped those ids and now names what each number is checked against (ImagoKit parity tests) and says the FFT room carries no lineage id, without promising one for later. The fixture moves for that reason only: the three constants are replaced with the current sentences, and each expected file text has the same sentences substituted verbatim (22 files, 44 lines). No input and no other byte of any expected text changes. The kit writers reproduce every pinned file byte for byte, as before. A new test, pinnedSentencesNameNoMilestone, fails on the old fixture and passes on the new one. Done: the CSV export pins name no internal milestone. Next: none for this issue. Fixes #42 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Paul · project thread
Fixes #42
Summary
Tests/ImagoFFTTests/Fixtures/csv-export-pins.jsonpinned the radial-profile and spots CSV sentences as macTEM wrote them when the pins were made, with internal milestone ids in the validation and lineage lines. macTEM main has since dropped those ids: itsFFTExportsentences now say "ImagoKit's parity tests" and "carries no lineage id". The fixture now carries those current sentences.pinnedSentencesNameNoMilestone: it fails on the old fixture and passes on the new one.The fixture move is its own commit, with the reason.
Test evidence
pinnedSentencesNameNoMilestonefailed with 4 issues on the old fixture.swift test -c release --parallel --skip ImagoKitParityTests: all green, including the byte-for-byte radial and spots writers against the moved pins.🤖 Generated with Claude Code