Repository navigation
ci: open Release PRs with the org release app when set up - #30
Merged
Merged
Conversation
… set up A Release PR opened with GITHUB_TOKEN gets pull_request runs that wait for approval, and its tags start no workflows. With the org variable RELEASE_APP_CLIENT_ID and secret RELEASE_APP_KEY set, the job mints an app token instead; unset, it falls back to GITHUB_TOKEN and the CI dispatch as before. Done: Release PRs can run CI without a tap. Next: the app and its two org settings (Paul). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Paul
What and why
Release PRs opened by release-please with
GITHUB_TOKENgetpull_requestruns that sit at "awaiting approval" (and the dispatched CI run does not count toward the PR's required check), so every Release PR needed a tap. This is the fix release-please documents: open the Release PR with a GitHub App token.actions/create-github-app-token@v3, org variableRELEASE_APP_CLIENT_ID, org secretRELEASE_APP_KEY) and release-please uses it. CI then runs on the Release PR like on any PR, and the release tag runs the tag workflows (version check, docs) that aGITHUB_TOKENtag never started.GITHUB_TOKENplus the CI dispatch). So this is safe to merge before the app exists.Checklist
swift test -c releasepasses: unaffected, release-please onlyci:releases nothing)🤖 Generated with Claude Code