Repository navigation
Design note for task 16: EELS zero-loss alignment, background, deconvolution, edge fit - #3
Merged
Merged
Conversation
…olution, edge fit docs/design/eels-task-16.md: the public API, exSpy 0.3.2 / HyperSpy 2.4.0 reference functions with their own tolerances (D17), pin scripts and fixtures, parity.md rows, implementation order (zero-loss alignment first for the macTEM EELS room), fast against parity target, Accelerate only. No code, no version bump, no CHANGELOG line. Done: the design a Mac session can implement. Next: a Mac session implements section 2 first. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UvFdXrEy5PVZ5s46XHQDp6
FFT1DDouble is power-of-two only; the deconvolutions use FFT2DDouble(nx: size, ny: 1). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UvFdXrEy5PVZ5s46XHQDp6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Paul · project thread
What and why
Adds
docs/design/eels-task-16.md, the design a Mac session implements for suite ROADMAP task 16 (SpectroKit 0.9.0): public API, exSpy 0.3.2 / HyperSpy 2.4.0 reference functions with their own tolerances (D17), pin scripts and fixtures under the existingtools/<slice>/pins.pylayout,docs/parity.mdrows, implementation order (zero-loss alignment first, for the macTEM EELS room), fast unit target against the parity target, Accelerate only (no Metal: nothing in the task is large enough to pay).Decisions to review: ImagoKit becomes a dependency for the any-length Double FFT; deconvolution tolerance rtol 1e-7 plus atol 1e-7 × max where exSpy tests nothing; the model fit is an exact minimiser (same deviation as the EDX fit); Richardson-Lucy designed but ordered last (ROADMAP lists it out of scope); L-edge tables for Mg, Al, Si, Fe, Cu.
Docs only. No code, no version bump, no CHANGELOG line.
Checklist
swift test -c releasepasses (no code changed)docs/parity.mdif the supported features changed (parity rows listed in section 9, to move when the code lands)validation: "none"are not described as validatedGenerated by Claude Code