Remove debug print from remove_fields - #92
Merged
Conversation
liquidz00
approved these changes
Aug 29, 2026
liquidz00
left a comment
liquidz00
left a comment
Collaborator
There was a problem hiding this comment.
@homebysix thank you for this, and apologies for the extra noise it caused!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove_fields()has a leftoverprint("Array item: ", i)that fires for every element of every list passed through a model's.xml()method. It's been in there since the open source release.We noticed it in an AWS Lambda that adds computers to a static group with
update_static_computer_group_membership_by_id(). One run wrote about 1,900 lines ofArray item: {'id': 1234}to CloudWatch alongside the real log output, and it grows with the size of the membership update. Since it's a print and not a logger call, there's no way to quiet it from the caller.Thanks for considering!