Skip to content

test: PR 3 on top of PR 2 (throwaway) - #4

Closed
ricardofrantz wants to merge 3 commits into
mainfrom
test/pr3-on-pr2
Closed

ricardofrantz wants to merge 3 commits into
mainfrom
test/pr3-on-pr2

Conversation

@ricardofrantz

@ricardofrantz ricardofrantz commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Throwaway check that PR 3 passes CI on top of PR 2. Will be closed.

View guided diff

claude and others added 3 commits October 26, 2026 13:56
The CI audit step failed with two critical findings in simple-git 3.36.0.
Version 4.0.2 is the first fixed release, and 3.x has no fix.
Version 4 has no default export, so gitService.ts now imports the named simpleGit.
The lockfile had 16 resolved URLs on a third-party mirror.
Point every resolved URL at registry.npmjs.org. The integrity values are unchanged.
Add scripts/check-lockfile-registry.js and a CI step that fails on any other registry.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016vMfdfTLtvm4G2UANfJw8q
The lockfile check read only the packages map.
A v1 lockfile keeps its entries in the dependencies tree, so the check found nothing.
Scan the packages map and the nested dependencies tree.
Fail if the lockfile has neither of them.
Add a self-test with one v1 fixture and one v3 fixture, and run it before the check.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016vMfdfTLtvm4G2UANfJw8q
Public repo: CodeRabbit reviews every PR. Draft PRs and bot dependency bumps are skipped.

Co-authored-by: Ricardo Frantz <4220623+ricardofrantz@users.noreply.github.com>
@ricardofrantz

Copy link
Copy Markdown
Collaborator Author

Throwaway check done: all three CI jobs passed.

@ricardofrantz
ricardofrantz deleted the test/pr3-on-pr2 branch October 30, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants