Repository navigation
test: PR 3 on top of PR 2 (throwaway) - #4
Closed
ricardofrantz wants to merge 3 commits into
Closed
ricardofrantz wants to merge 3 commits into
ricardofrantz wants to merge 3 commits into
Conversation
The CI audit step failed with two critical findings in simple-git 3.36.0. Version 4.0.2 is the first fixed release, and 3.x has no fix. Version 4 has no default export, so gitService.ts now imports the named simpleGit. The lockfile had 16 resolved URLs on a third-party mirror. Point every resolved URL at registry.npmjs.org. The integrity values are unchanged. Add scripts/check-lockfile-registry.js and a CI step that fails on any other registry. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016vMfdfTLtvm4G2UANfJw8q
The lockfile check read only the packages map. A v1 lockfile keeps its entries in the dependencies tree, so the check found nothing. Scan the packages map and the nested dependencies tree. Fail if the lockfile has neither of them. Add a self-test with one v1 fixture and one v3 fixture, and run it before the check. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016vMfdfTLtvm4G2UANfJw8q
Public repo: CodeRabbit reviews every PR. Draft PRs and bot dependency bumps are skipped. Co-authored-by: Ricardo Frantz <4220623+ricardofrantz@users.noreply.github.com>
Collaborator
Author
|
Throwaway check done: all three CI jobs passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway check that PR 3 passes CI on top of PR 2. Will be closed.