Repository navigation
Conversation
…resource The comment cited MSFT_IntuneDeviceConfigurationPolicyWindows10, a Windows 10 device configuration resource, through a link that returns a 404. It now cites MSFT_IntuneMobileThreatDefenseConnector, the file the table comes from, and notes where the table differs from it, as in maester365#2754.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Up to standards ✅🟢 Issues
|
earbona23
left a comment
There was a problem hiding this comment.
Verified every claim in this PR, and one of them has expired since you opened it — in your favour.
The 404 is real
| URL | HTTP |
|---|---|
the current DSCResources/... link in main |
404 |
the same path with DscResources |
200 |
your MSFT_IntuneMobileThreatDefenseConnector link |
200 |
Confirmed through the API as well as the browser, so it is a genuine missing path and not a bot block: contents/Modules/Microsoft365DSC/DSCResources/... returns 404 while DscResources/... returns the folder. Case-sensitive path, exactly as you say.
It is the right source
I compared MT.1098's 16 entries against MSFT_IntuneMobileThreatDefenseConnector.psm1 on Dev today, both the IDs and the display names:
MT.1098: 16 pairs | DSC resource: 16 pairs
IDs only in MT.1098: none
IDs only in the resource: none
names that differ: 0
So the comment is pointing at the file the table actually comes from.
Your divergence note was true and is now stale
That same comparison means the last line no longer holds, and the reason is worth seeing:
- You opened this PR at 2026-11-09 20:55Z.
MSFT_IntuneMobileThreatDefenseConnector.psm1was changed at 2026-11-10 09:28Z, commit8e929c8, message "Fix connector ids":
- '4873197-ffec-4dfc-9816-db65f34c7cb9' = 'Trellix Mobile Security'
+ '74873197-ffec-4dfc-9816-db65f34c7cb9' = 'Trellix Mobile Security'
- 'e6f777f8-e4c2-4a5b-be01-50b5c124bc7f' = 'Windows Security Center'
+ 'c2b688fe-48c0-464b-a89c-67041aa8fcb2' = 'Windows Security Center'
+ 'fc06ff9b-e2f9-4221-9a68-465684ee8662' = 'iVerify'Those are precisely the three you flagged: a Trellix ID missing its leading 7, a Windows Security Center ID that was wrong, and iVerify absent. Thirteen hours after you wrote the note, upstream corrected all three to the values Maester already had. Your reading was right; the file caught up.
So I would change the third line to say the table matches the resource, or drop it — as written it would ship a claim that is false today, in a PR whose whole purpose is a comment being accurate.
And since blob/Dev/... is a moving target that just moved under this PR, pinning the link to a commit SHA rather than the branch would stop the same thing happening to the next reader.
No collision with #2794
I have a PR open on this same file (#2794, the Windows Security Center MAM reason). It touches the attribute, the notSetUp arm and the heartbeat line, not these two comment lines, so git merge-tree shows no conflict either way round. Whichever lands first, I will rebase mine — no need to sequence them.
…gence note Microsoft365DSC PR 7611 corrected the Trellix and Windows Security Center IDs and added iVerify on November 10, so the note that the table differs from the resource no longer held. The link is now pinned to the Dev commit where the resource's 16 entries were compared with the table and found identical.
|
Thanks for checking all of it. You're right: Microsoft365DSC/Microsoft365DSC#7611 landed the morning after I opened this, so the third line had expired. Pushed 3bc5c32: the link is now pinned to Microsoft365DSC/Microsoft365DSC@b91a708 on Dev (November 11), where the resource's 16 IDs and names match the table one for one, and the comment says so. It also notes that the Trellix, Windows Security Center and iVerify IDs were checked against Graph in a tenant. Description updated. If the ubuntu build-validation fails on this push, it comes from main, as explained on #2794. |
|
Two things, and the second is the one I would have got wrong without checking. 1. The four failures on the Linux leg are not yours. 2. The which reads exactly like a parameter-binding bug. It is not. I counted the same lines in two PRs whose Flagging it because that was the one thing in your log that looked actionable, and chasing it would have been time spent on the harness's own happy path. Thanks again for running MT.1098 against the #2595 tenant on #2794 — that measurement is what let the narrow guard land with evidence instead of argument. |
|
Thanks @earbona23, that matches what I saw: the four Linux failures are main's, none in MT.1098. Thanks too for checking the Smoke_Error lines against green builds. Glad the measurement helped on #2794. |
earbona23
left a comment
There was a problem hiding this comment.
Approving. Pinning the source to a commit is the right call, and I verified the pin rather than just the link.
| check | result |
|---|---|
| the pinned URL resolves | HTTP 200 |
the pin contains 8e929c8 "Fix connector ids" |
yes — compare reports the pin 18 commits ahead, 0 behind |
| MT.1098's table vs the pinned resource | 16 pairs each, 0 IDs only on one side, 0 names differing |
BOM on Test.MT.1098.ps1 |
present (ef bb bf) |
That last row matters because it is what makes the new wording true rather than merely plausible: the comment claims the same 16 entries at that commit, and they are identical both ways.
It also fixes the problem a branch link has: the previous comment pointed at Dev, so the day Microsoft365DSC changed the file the comment silently became wrong — which is exactly what happened to your original divergence note between opening the PR and this change. A pinned commit cannot rot that way, and dropping the stale note while keeping the sentence about the three IDs you checked in a tenant keeps the part that a reader still needs.
📑 Description
The comment above MT.1098's connector ID table cites
MSFT_IntuneDeviceConfigurationPolicyWindows10, a Windows 10 device configuration resource, and its link returns a 404 (the folder isDscResources). This brings over the comment from #2754, closed when #2753 was merged, and updates it: it points atMSFT_IntuneMobileThreatDefenseConnector, the resource the table comes from, and says that its 16 entries match the table, with the link pinned to the commit checked (Microsoft365DSC/Microsoft365DSC#7611 corrected the Trellix and Windows Security Center IDs and added iVerify on November 10). The link uses the repository's current address,Microsoft365DSC/Microsoft365DSC;microsoft/Microsoft365DSCnow redirects there.✅ Checks
/powershell/tests/pester.ps1locally.ℹ️ Additional Information
Comments only: no change to the check or its tests.
Summary by CodeRabbit