Repository navigation
feat(cisa)!: take parked domains from the ParkedDomains setting in the Exchange email checks - #2787
Conversation
|
Caution Review failedThe pull request is closed. Walkthrough
Merge Risk:
|
Up to standards ✅🟢 Issues
|
…e Exchange email checks CISA.MS.EXO.2.2 and CISA.MS.EXO.3.1 no longer read Exchange's SendingFromDomainDisabled to decide which accepted domains are parked. - MS.EXO.2.2 (SPF) takes a ParkedDomains parameter bound to the shared setting. A listed domain must publish a policy that fails all senders (-all or ~all, as MS.EXO.2.2v3 allows); every other accepted domain gets the sending-domain check, including one that cannot send. - MS.EXO.3.1 (DKIM) checks every accepted domain except the coexistence domain. SCuBA gives no separate rule for a domain that never sends, so the skip for parked domains is removed rather than moved to the setting. - MS.EXO.4.2, 4.3 and Test-MtCisaDmarcReport already check every domain; the commented-out inference is replaced by a comment that says so. Co-Authored-By: Claude <noreply@anthropic.com> Entire-Checkpoint: 01M73H4Z79A9A32WNWWS1A4B92
…data Co-Authored-By: Claude <noreply@anthropic.com> Entire-Checkpoint: 01M74513ATGD00B8M71K7WEFPQ
98f45d9 to
8b6f8ab
Compare
Stacked on #2758 (base
feat/parameter-settings). Design: #2775.The CISA Exchange email-authentication tests no longer decide which accepted domains are parked from Exchange's
SendingFromDomainDisabled. A domain is parked only when it is listed in the sharedParkedDomainssetting, which the engine binds to a test parameter. No test callsGet-MtSetting.Breaking change
Results change for tenants that relied on Allow mail to be sent from this domain being turned off:
ParkedDomains. A listed domain must publish a policy ending in-allor~allTo keep a parked domain passing 2.2, list it once:
{ "GlobalSettings": { "ParkedDomains": ["contoso-old.com"] } }What SCuBA asks of a parked domain
Read from the ScubaGear baseline (
baselines/exo.md),EXOConfig.regoandExportEXOProvider.psm1. ScubaGear has no notion of a parked domain: it runs every policy against every accepted domain (the coexistence domain aside) and never readsSendingFromDomainDisabled.-allor~allboth comply-allor~all. With no approved senders that isv=spf1 -allParkedDomains. A listed domain is not asked for the Exchange Online include (Maester's check for a sending domain) and must fail all sendersp=rejectp=rejectruaincludesreports@dmarc.cyber.dhs.govTest-MtCisaDmarcReport)ruaandrufSo only MS.EXO.2.2 takes
ParkedDomains. The others keep the sending-domain check for every domain because the baseline gives no other rule.Decided in #2775 (decision 6): the CISA Exchange tests use the
ParkedDomainssetting instead of inferring fromSendingFromDomainDisabled, and CISA.MS.EXO.3.1 keeps checking DKIM on every domain, parked or not, because SCuBA has no separate rule for a parked domain.Changes
Test.CISA.MS.EXO.2.2.ps1:ParkedDomainsparameter bound to the setting; parked-domain rule; checks all accepted domains. Names are matched without regard to case or a trailing dot.Test.CISA.MS.EXO.3.1.ps1: removes theSendingFromDomainDisabledskip and the "Disable sending from domain" recommendation that depended on it.Test.CISA.MS.EXO.4.2.ps1,Test.CISA.MS.EXO.4.3.ps1,Test-MtCisaDmarcReport.ps1: the commented-out inference becomes a one-line comment. No behaviour change.Test-MtCisaSpfDirective.Tests.ps1(11 cases);Test-MtDkim.Tests.ps1expects a failure for the CISA parked case.Not changed:
tests/cis/,MaesterSettings.psd1,powershell/internal/engine/.website/docs/configuration/does not list tests per setting, andUpdate-MtTestBuilderData.ps1produced no diff.Notes
powershell/tests/functions/Test-MtDkim.Tests.ps1(the same parked case, for CIS), so whichever merges second has a small conflict there.-all, which is narrower than MS.EXO.2.2v3. Left for a separate change.Testing
./powershell/tests/pester.ps1: 8542 tests, no failures. Not run against a tenant.🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Bug Fixes
Documentation