Repository navigation
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Up to standards ✅🟢 Issues
|
earbona23
left a comment
There was a problem hiding this comment.
Checked the mechanical side, on main at 2d659e8:
ContributorNames.Tests.ps1passes with the entry in place, 69 of 69 (67 before, plus the two names this and #2808 add).- The handle is placed in order:
joshuafdo<julien-ly<kayasax. The registry has three entries out of order today and this is not one of them. - Merges clean onto
main, and clean alongside #2808, which inserts into the same file a few hundred lines up.
The capitalization rule the test enforces is satisfied: Julien Ly, both words capitalized, no particles.
The contents are yours to state, so this is not a judgement on the title, company or links — only that nothing here breaks the registry or the site's generator.
Overdue thanks for the lab runs on #2794 and #2694. The second decided a design question I had been sitting on for six days.
|
Thanks, and the thanks go both ways. On #2694 you turned a lab reading into a design decision, code and tests included, by the next day. On #2794 you folded in the wording points and closed the MAM case on the measurement. On #2807 and #2811 you re-ran each branch yourself and said exactly what you had measured. That rigor, and the speed that comes with it, is what makes a run on a real tenant worth the time. |
earbona23
left a comment
There was a problem hiding this comment.
Approving. Verified against main at the current head (3e91eff):
- Single file touched, additive only:
website/contributors/contributors.yml, +9/-0. - Key placement is correct:
julien-lysits betweenjoshuafdoandkayasax, so the case-insensitive ordering of the file holds. - YAML parses with the entry applied, and the website contributor tests pass (69/69).
- No conflict with #2808, which adds its entry in a different region of the same file; the two apply cleanly in either order.
One note so the red check is not misread: build-validation (ubuntu-latest) is failing on main itself and has been since 11 Nov, so every open PR inherits it. It is not caused by this change. #2795 and #2797 cover the four failing tests.
Thanks as well for the lab data on MT.1268 and the two corrections on MT.1098 — both are applied.
📑 Description
Add my contributor profile: name, title, company, location, website and LinkedIn. It enriches the existing
/contributors/julien-lypage through the contributor registry.✅ Checks
/powershell/tests/pester.ps1locally.ℹ️ Additional Information
Parsed the YAML: the new entry reads as intended and the other 83 entries are unchanged.
git diff --checkpasses, and so doespowershell/tests/general/ContributorNames.Tests.ps1, the test that covers this file (68/68).Summary by CodeRabbit