Skip to content

fix: restore FiraSenax test contributor credits - #2810

Open
FiraSenax wants to merge 1 commit into
maester365:mainfrom
FiraSenax:codex/fix-firasenax-test-credits
Open

FiraSenax wants to merge 1 commit into
maester365:mainfrom
FiraSenax:codex/fix-firasenax-test-credits

Conversation

@FiraSenax

@FiraSenax FiraSenax commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

📑 Description

The contributor page currently credits FiraSenax for MT.1098 only. Two merged contributions are missing from the native test metadata: the Exchange access-policy fix in #2735 and the Markdown-escaping fix across 14 Entra Agent ID checks in #2774.

Append FiraSenax to Contributor in MT.1058 and add the contributor to MT.1200, MT.1201, MT.1203–MT.1213 and MT.1223. Preserve all existing authors and contributors. The website attribution generator then credits 16 improved tests, including the existing MT.1098 credit.

✅ Checks

  • My pull request adheres to the code style of this project.
  • Get-MtTest -Id <15 changed IDs> reports IsValid = True, no metadata errors, and FiraSenax in Contributor for all 15 tests.
  • The production computeContributorData generator, using the exported built-in test metadata and full git history, produces exactly 16 improved tests and zero authored tests for FiraSenax.
  • Byte comparison confirms that only the intended credit entries changed; existing credits, UTF-8 BOMs, executable code and all other metadata are preserved.
  • git diff --check passed.
  • The build and unit tests pass after running /powershell/tests/pester.ps1 locally.

ℹ️ Additional Information

Ran the full powershell/tests/pester.ps1 wrapper: 195 test files, 8,756 test cases, four failures. NativeTestAttributes, NativeTestLint, PSScriptAnalyzer, Golden, and the Exchange access-policy and Entra Agent ID regression tests passed, including all 136 Agent Markdown cases.

The four failures are outside the changed metadata:

  • FileEncoding: powershell/tests/functions/Invoke-MtPackGitHubRequest.Tests.ps1 lacks a BOM. Reproduced on unchanged main.
  • ConsoleOutput: the GitHub Actions colour expectation fails in this host. Reproduced on unchanged main.
  • AgentFiles: macOS marks the workspace's agent source files and skill folders as Hidden, so the generator omits them. All relevant source and generated-document bytes match main; the check passes in a clean temporary checkout.
  • TestAttributes / catalog-build rejection fixture: the child build unexpectedly returns 0 inside the workspace; the same test passes in a clean temporary checkout.

Copied the exact 15-file patch to the clean temporary checkout and reran both workspace-dependent failures together: both passed (2/2).

No tenant validation was performed; this change only corrects attribution metadata. The separate profile-enrichment PR is #2808.

Summary by CodeRabbit

  • Chores
    • Updated contributor credits across multiple Entra security tests. Test behavior and results are unchanged; this update affects attribution only.

@FiraSenax
FiraSenax requested a review from a team as a code owner November 14, 2026 12:27
@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Contributor metadata in 15 Entra tests now credits FiraSenax. The test implementations are unchanged.

Changes: Entra test metadata

Layer / File(s) Summary
Update Entra test contributor metadata
tests/maester/entra/Test.MT.1058.ps1, tests/maester/entra/Test.MT.1200.ps1–Test.MT.1213.ps1, tests/maester/entra/Test.MT.1223.ps1
The test metadata adds FiraSenax as a contributor. Existing author declarations remain unchanged where present.

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Bug fix

Suggested reviewers: merill

Merge Risk: Minimal · up to 0d759

This change only updates contributor credits in test metadata and does not change runtime behavior. It is low risk and safe to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title 'fix: restore FiraSenax test contributor credits' matches the changeset. The raw summary shows contributor metadata added for FiraSenax across the listed MT test files, and the PR objectives…
Description check Passed The description follows the template's main sections: Description, Checks, and Additional Information. It explains the change, the affected test IDs, and the reason for it. It lists the validation per…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title 'fix: restore FiraSenax test contributor credits' matches the changeset. The raw summary shows contributor metadata added for FiraSenax across the listed MT test files, and the PR objectives state the same purpose. The title is short, specific, and follows a conventional commit style.

Full details: Description check

Explanation

The description follows the template's main sections: Description, Checks, and Additional Information. It explains the change, the affected test IDs, and the reason for it. It lists the validation performed and reports four unrelated test failures with their causes. The template's Closes issue line is left as a placeholder, and the 'build and unit tests pass' checkbox is unchecked. The author explains the failures, so the gaps are minor.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 2d659e8 and 0d75996.

Files selected for processing: 15

  • tests/maester/entra/Test.MT.1058.ps1
  • tests/maester/entra/Test.MT.1200.ps1
  • tests/maester/entra/Test.MT.1201.ps1
  • tests/maester/entra/Test.MT.1203.ps1
  • tests/maester/entra/Test.MT.1204.ps1
  • tests/maester/entra/Test.MT.1205.ps1
  • tests/maester/entra/Test.MT.1206.ps1
  • tests/maester/entra/Test.MT.1207.ps1
  • tests/maester/entra/Test.MT.1208.ps1
  • tests/maester/entra/Test.MT.1209.ps1
  • tests/maester/entra/Test.MT.1210.ps1
  • tests/maester/entra/Test.MT.1211.ps1
  • tests/maester/entra/Test.MT.1212.ps1
  • tests/maester/entra/Test.MT.1213.ps1
  • tests/maester/entra/Test.MT.1223.ps1

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@earbona23

Copy link
Copy Markdown
Contributor

Checked the one thing a self-attribution PR should be checked on: whether every credit it claims is backed by a merged contribution, and whether it claims any that is not.

Both halves hold. Cross-referencing the files this PR touches against the .ps1 files of the two PRs it cites:

#2735 (merged 2026-11-09) Test.MT.1058.ps1 — 1 test
#2774 (merged 2026-11-10) MT.1200, MT.1201, MT.1203–MT.1213, MT.1223 — 14 tests
files this PR changes 15
claimed here but not in those merged PRs 0

So the credit set is exactly the contribution set, with nothing added. The three remaining .ps1 files from those PRs — Test-MtSpExchangeAppAccessPolicy.Tests.ps1, Test-MtEntraAgentMarkdown.Tests.ps1, Test-MtEntraAgentSecurity.Tests.ps1 — are unit-test files with no [MaesterTest] block and therefore no Contributor field, so leaving them out is correct rather than an omission.

The diff touches nothing else. Of the 209 diff lines, every single +/- line matches Author or Contributor; there is no executable change hiding in a 15-file attribution PR. That is the claim in your checklist and it holds when measured.

On the format, since 14 of the 15 get a bare string: main is split 58 bare strings to 34 tuples for Contributor, so the bare string is the majority form and MT.1058 correctly keeps the tuple it already had with FiraSenax appended. Existing authors and contributors are preserved everywhere.

One note for whoever merges, not a change request: the FileEncoding failure you reported is the missing byte order mark on Invoke-MtPackGitHubRequest.Tests.ps1, and it is the repository's, not yours — #2795 removes it. Measured today, build-validation (ubuntu-latest) fails on 28 of the 45 open non-draft PRs, and no PR whose Pester step actually runs has passed since 11 Nov, so your four failures reproducing on unchanged main is the expected shape right now.

Nothing blocking from me.

@earbona23 earbona23 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. This is a self-attribution PR touching fifteen files authored by other people, so I verified the claim from the history rather than taking it on trust — and it holds exactly.

The credit is earned, file for file

Every one of the fifteen files is a file you changed in a merged PR:

your PR merged files among the fifteen
#2774 fix(entra): escape Markdown in agent check results 2026-11-10, 8dbb86d 14 — MT.1200, 1201, 1203, 1204, 1205, 1206, 1207, 1208, 1209, 1210, 1211, 1212, 1213, 1223
#2735 fix(entra): require RestrictAccess policies in MT.1058 2026-11-09, d101067 1 — MT.1058

14 + 1 = 15, and the set matches this PR's fifteen with nothing left over on either side. So the work is in main, attributable, and the Contributor attribute simply never caught up with it.

The syntax matches the repo too: a single unparenthesised value is the majority form, 118 files in main against 66 using a tuple. Golden suite green, 13/13.

One wording correction

The title and the commit say restore, and that is the one thing I could not confirm — the credits were never there to begin with. Measured:

git log -S"FiraSenax" --all -- <the fifteen files>
  -> 0d75996e6  (this PR's own commit, and nothing before it)

git log -S"FiraSenax" origin/main -- tests/maester/entra
  -> 0 commits

In main today FiraSenax appears as a contributor in exactly one file, tests/maester/intune/Test.MT.1098.ps1, which is not one of these. So this adds credit that was owed and never recorded; it does not restore credit that was removed. Nothing in the diff changes, but "add" rather than "restore" is the accurate word, and it matters here precisely because a reader who checks the history will find no removal and may read the title as a claim that did not happen — which would be unfair to a change that is entirely justified.

Worth noting the general shape for other authors: the fifteen checks were each modified by a merged PR whose attribute block was left alone, so there are almost certainly other contributors in the same position across the suite. A reviewer cannot tell an owed credit from an unowed one by looking at the diff; the two merged PRs are what settle it, and linking them in the PR body would have saved anyone else the same dig.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants