Repository navigation
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Up to standards ✅🟢 Issues
|
|
Checked the one thing a self-attribution PR should be checked on: whether every credit it claims is backed by a merged contribution, and whether it claims any that is not. Both halves hold. Cross-referencing the files this PR touches against the
So the credit set is exactly the contribution set, with nothing added. The three remaining The diff touches nothing else. Of the 209 diff lines, every single On the format, since 14 of the 15 get a bare string: One note for whoever merges, not a change request: the Nothing blocking from me. |
earbona23
left a comment
There was a problem hiding this comment.
Approving. This is a self-attribution PR touching fifteen files authored by other people, so I verified the claim from the history rather than taking it on trust — and it holds exactly.
The credit is earned, file for file
Every one of the fifteen files is a file you changed in a merged PR:
| your PR | merged | files among the fifteen |
|---|---|---|
| #2774 fix(entra): escape Markdown in agent check results | 2026-11-10, 8dbb86d |
14 — MT.1200, 1201, 1203, 1204, 1205, 1206, 1207, 1208, 1209, 1210, 1211, 1212, 1213, 1223 |
| #2735 fix(entra): require RestrictAccess policies in MT.1058 | 2026-11-09, d101067 |
1 — MT.1058 |
14 + 1 = 15, and the set matches this PR's fifteen with nothing left over on either side. So the work is in main, attributable, and the Contributor attribute simply never caught up with it.
The syntax matches the repo too: a single unparenthesised value is the majority form, 118 files in main against 66 using a tuple. Golden suite green, 13/13.
One wording correction
The title and the commit say restore, and that is the one thing I could not confirm — the credits were never there to begin with. Measured:
git log -S"FiraSenax" --all -- <the fifteen files>
-> 0d75996e6 (this PR's own commit, and nothing before it)
git log -S"FiraSenax" origin/main -- tests/maester/entra
-> 0 commits
In main today FiraSenax appears as a contributor in exactly one file, tests/maester/intune/Test.MT.1098.ps1, which is not one of these. So this adds credit that was owed and never recorded; it does not restore credit that was removed. Nothing in the diff changes, but "add" rather than "restore" is the accurate word, and it matters here precisely because a reader who checks the history will find no removal and may read the title as a claim that did not happen — which would be unfair to a change that is entirely justified.
Worth noting the general shape for other authors: the fifteen checks were each modified by a merged PR whose attribute block was left alone, so there are almost certainly other contributors in the same position across the suite. A reviewer cannot tell an owed credit from an unowed one by looking at the diff; the two merged PRs are what settle it, and linking them in the PR body would have saved anyone else the same dig.
📑 Description
The contributor page currently credits FiraSenax for MT.1098 only. Two merged contributions are missing from the native test metadata: the Exchange access-policy fix in #2735 and the Markdown-escaping fix across 14 Entra Agent ID checks in #2774.
Append FiraSenax to
Contributorin MT.1058 and add the contributor to MT.1200, MT.1201, MT.1203–MT.1213 and MT.1223. Preserve all existing authors and contributors. The website attribution generator then credits 16 improved tests, including the existing MT.1098 credit.✅ Checks
Get-MtTest -Id <15 changed IDs>reportsIsValid = True, no metadata errors, and FiraSenax inContributorfor all 15 tests.computeContributorDatagenerator, using the exported built-in test metadata and full git history, produces exactly 16 improved tests and zero authored tests for FiraSenax.git diff --checkpassed./powershell/tests/pester.ps1locally.ℹ️ Additional Information
Ran the full
powershell/tests/pester.ps1wrapper: 195 test files, 8,756 test cases, four failures. NativeTestAttributes, NativeTestLint, PSScriptAnalyzer, Golden, and the Exchange access-policy and Entra Agent ID regression tests passed, including all 136 Agent Markdown cases.The four failures are outside the changed metadata:
FileEncoding:powershell/tests/functions/Invoke-MtPackGitHubRequest.Tests.ps1lacks a BOM. Reproduced on unchanged main.ConsoleOutput: the GitHub Actions colour expectation fails in this host. Reproduced on unchanged main.AgentFiles: macOS marks the workspace's agent source files and skill folders as Hidden, so the generator omits them. All relevant source and generated-document bytes match main; the check passes in a clean temporary checkout.TestAttributes/ catalog-build rejection fixture: the child build unexpectedly returns 0 inside the workspace; the same test passes in a clean temporary checkout.Copied the exact 15-file patch to the clean temporary checkout and reran both workspace-dependent failures together: both passed (2/2).
No tenant validation was performed; this change only corrects attribution metadata. The separate profile-enrichment PR is #2808.
Summary by CodeRabbit