Skip to content

feat(ad): verify NTAuth CA certificate paths against published roots - #2812

Open
FiraSenax wants to merge 97 commits into
maester365:mainfrom
FiraSenax:codex/ntauth-certificate-chain
Open

FiraSenax wants to merge 97 commits into
maester365:mainfrom
FiraSenax:codex/ntauth-certificate-chain

Conversation

@FiraSenax

@FiraSenax FiraSenax commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds AD-PKI-13, an informational native check that verifies generic CA certificate paths from the forest's NTAuth store to roots published in AD. It handles Microsoft and third-party CA certificates without requiring a pKIEnrollmentService registration.

Intentionally depends on #2734, based on its head bf1709daaf89373886caf332e1dcd68fc91af528, to reuse @soulemike's shared certificate inventory and parser. Merge #2734 first, then rebase this follow-up onto main. Until then, review the five-file incremental diff for this extension. The existing NTAuth inventory remains AD-CFG-21.

Behavior

  • Reads the cached configuration snapshot and reuses Ad test consolidation #2734's public-certificate parser. No additional LDAP transport or second inventory check.
  • Builds offline .NET chains with CustomRootTrust from TrustedRootCAs. Published intermediate, enterprise-CA and NTAuth certificates supply possible issuers. A certificate available only from the runner's OS cache cannot make a path verify.
  • Verifies signatures, validity and constraints; requires the NTAuth input to be a CA; counts each non-self-issued subordinate CA, including the NTAuth CA, against issuer path-length limits. Deduplicates by SHA-256 certificate identifier.
  • Returns Passed for verified published paths, Investigate for unverifiable paths, NotApplicable for an observed empty NTAuth store, and Error for unavailable or malformed evidence. The empty-store result includes the specific explanation and an explicit return. Tables escape certificate-controlled HTML and Markdown.
  • Extends the shared parser with optional public DER output and support for single and multi-valued DER certificates flattened into object arrays of bytes by LDAP projection. Mixed non-byte input remains an error.

Scope and classification

Product=ad, Feature=certificate-services, Area=authentication, ResourceType=CertificateAuthority, Info / Preview, Mitre=None, Control=nist-800-53-r5:SC-17. This is evidence about a published certificate path, not an authentication-risk verdict; it does not affect scores. It supports only the certificate-path portion of SC-17.

No AIA downloads, revocation requests, private-key access, certificate enrollment or PKINIT are performed by the check. It does not apply smart-card/client-auth EKU policy, establish organizational root approval, or assess actual DC trust, certificate mappings, effective enrollment permissions, templates or the issuing CA's policy. Missing issuers remain visible inventory gaps. NTAuth authorization and root trust are separate inputs; AD publication does not prove that a DC trusts a root.

Validation

  • 64 focused tests passed: 55 certificate-path/native-engine cases and nine existing certificate-inventory tests. The path suite includes all 20 combinations of one through four subordinate CAs and root path-length constraints 0 through 4, including valid boundaries and exceeded limits. Certificate parsing, signatures and chain validation are real; directory reads in the unit cases are mocked.
  • The visible empty-store-message regression failed on the original implementation and passes with the fix, preserving Skipped / NotApplicable.
  • The deeper live matrix exposed a second DER projection defect when one LDAP object publishes multiple certificates. The observed nested arrays are now normalized per certificate, with regressions for all four inventory roles and mixed/malformed input. 15 regression cases failed before this parser fix; all 64 focused cases pass afterwards.
  • The repository runner covered 207 files / 8,480 cases: 8,383 passed, 93 skipped, four failures. All four failures were reproduced on unchanged PR head a95f6db9c in a separate checkout: the three OU modification-date cases and this Mac's GitHub Actions colour expectation. No entirely green full-suite run is claimed. Native metadata/lint, layout, complete ScriptAnalyzer coverage and Golden selection/config/legacy-tag tests passed.
  • Module build and built-output validation passed. Built AD-PKI-13 metadata is valid with no errors, and remains Info / Preview.
  • 34/34 final live AD/LDAP scenarios matched on an isolated Windows Server 2025 DC clone using PowerShell 7.5.4, native Invoke-MtTest, fresh processes and validated LDAPS without certificate-check bypasses. All 20 root/depth combinations passed their expected outcomes, including five-certificate paths, the visible empty-store message and restored valid state. The multi-valued projection defect was reproduced on the real LDAP data before the fix and verified afterwards. Runtime parser/helper/check hashes matched the final source; every scenario had zero enterprise CA registrations. Public CA objects and signed empty CRLs were fixtures, not a running CA issuance service. Fixture objects, VM, ISO, bridge, namespace and helper payloads were removed. The source VM remained stopped and all unrelated guest identities/run states were preserved.
  • At a95f6db9c, the main-based attribute review could not complete because 50 tests needed review, above the workflow's limit of 25. CodeRabbit also skipped the inherited 567-file diff. These review-capacity limits include Ad test consolidation #2734; rebase after it merges to review the incremental change. Attribute-review workflow.

The overlap audit covered main, local PKI work, open PR metadata and targeted searches, including #2734's changed-file patches. #2734 inventories public certificates and expiry observations; #2804/#2806 evaluate AD CS template prerequisites. This extension adds NTAuth-to-published-root cryptographic path assessment.

Sources: NTAuth publication, third-party CA authentication prerequisites, .NET chain policy.

Additional running AD CS / HTTP validation (2026-11-15)

A separate seven-VM lab used actual Windows Server 2025 Datacenter guests: a DC clone, five freshly installed AD CS servers and a fresh workgroup client. The hierarchy was Root + four subordinate CAs + an enterprise-issued WebServer certificate, with path-length limits 4/3/2/1/0. CertSvc issued the certificates and signed the CRLs; HTTP served their public publication files. Upper CA services were stopped during client validation.

  • 21/21 online scenarios matched: cold and warm caches, HTTP AIA 404/invalid content, HTTP CRL 404/invalid content, untrusted root, actual leaf and intermediate-CA revocation, reinstatement and expiry. The same signed CRL passed before its real NextUpdate and failed afterwards with unchanged bytes; normal CRL restoration passed. Independent certutil -verify -urlfetch exited 0.
  • The root-only cold client exposed Windows' two-AIA-fetch limit per chain build, producing PartialChain. The complete six-certificate server path passed with two upper intermediates explicitly supplied through ExtraStore, two issuers fetched over HTTP and all five required CRLs fetched over HTTP. A separate cold CA-path case fetched the upper two issuers. No four-fetch single-build success is claimed. Microsoft documentation.
  • Five native AD-PKI-13 scenarios matched against the real published CA hierarchy with one enterprise CA registration, validated LDAPS and exact final parser/helper/check hashes. Full inventory passed; a missing published intermediate produced Investigate even while HTTP retrieval worked. HTTP outages and revoked CA certificates still passed the native check, confirming its explicitly offline, no-revocation scope.
  • HTTP access logs, CAPI2 events, public certificate/CRL versions and configuration evidence were retained locally and hash-verified. All seven temporary VMs, setup ISOs, private lab files and isolated network resources were removed. The source VM stayed stopped and unrelated guest identities/run states were preserved.

No product-code change was needed for this additional validation. PKINIT/authentication and OCSP were not tested.

Ready for incremental review. Merge #2734 first, then rebase this follow-up; the Maester 3.0 feature freeze still governs merge timing.

@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Too many files!

This PR contains 567 files, which is 417 over the limit of 150.

To get a review, reduce the PR to 150 files or fewer by splitting it into smaller PRs or changing its base branch.

Upgrade to a paid plan to raise the limit.

Usage-priced reviews support at most 300 files.

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 2d659e8 and cd264a6.

Files selected for processing: 567

  • build/golden/Export-MtLegacyTagTable.ps1
  • build/golden/native-test-replacements.psd1
  • powershell/assets/Maester.LegacyTags.json
  • powershell/internal/checks/ad/ad/Assert-MtAdUserAccountControl.ps1
  • powershell/internal/checks/ad/ad/ConvertTo-MtAdConfigurationInventoryCell.ps1
  • powershell/internal/checks/ad/ad/Format-MtAdSiteInventoryValue.ps1
  • powershell/internal/checks/ad/ad/Format-MtAdSummaryTable.ps1
  • powershell/internal/checks/ad/ad/Format-MtAdUserSecurityTable.ps1
  • powershell/internal/checks/ad/ad/Get-MtAdCertificateInventory.ps1
  • powershell/internal/checks/ad/ad/Get-MtAdConfigurationInventory.ps1
  • powershell/internal/checks/ad/ad/Get-MtAdConfigurationInventorySiteLinkTransport.ps1
  • powershell/internal/checks/ad/ad/Get-MtAdDomainControllerRelease.ps1
  • powershell/internal/checks/ad/ad/Get-MtAdDomainControllersInScope.ps1
  • powershell/internal/checks/ad/ad/Get-MtAdDomainNameFindings.ps1
  • powershell/internal/checks/ad/ad/Get-MtAdFsmoPlacement.ps1
  • powershell/internal/checks/ad/ad/Get-MtAdFunctionalLevelAssessment.ps1
  • powershell/internal/checks/ad/ad/Get-MtAdOrganizationalUnitOverview.ps1
  • powershell/internal/checks/ad/ad/Get-MtAdPasswordPolicyUsage.ps1
  • powershell/internal/checks/ad/ad/Get-MtAdSiteSubnetOverview.ps1
  • powershell/internal/checks/ad/ad/Get-MtAdStateCollection.ps1
  • powershell/internal/checks/ad/ad/Get-MtAdSubnetInventory.ps1
  • powershell/internal/checks/ad/ad/Get-MtAdUserPathFindings.ps1
  • powershell/internal/checks/ad/ad/Invoke-MtAdConfigurationInventoryReport.ps1
  • powershell/internal/checks/ad/ad/Test-MtAdPasswordPolicyConfiguration.ps1
  • powershell/internal/checks/ad/ad/Test-MtAdUserOrdinaryIdentity.ps1
  • powershell/internal/services/ad/Get-MtAdNtAuthCertificatePath.ps1
  • powershell/internal/services/ad/Test-MtAdDomainControllerAccount.ps1
  • powershell/internal/services/ad/protocol/ConvertFrom-MtLdapValue.ps1
  • powershell/internal/services/ad/queries/Get-MtLdapComputer.ps1
  • powershell/internal/services/ad/queries/Get-MtLdapConfigurationContainer.ps1
  • powershell/internal/services/ad/queries/Get-MtLdapDomain.ps1
  • powershell/internal/services/ad/queries/Get-MtLdapDomainController.ps1
  • powershell/internal/services/ad/queries/Get-MtLdapFineGrainedPasswordPolicy.ps1
  • powershell/internal/services/ad/queries/Get-MtLdapForest.ps1
  • powershell/internal/services/ad/queries/Get-MtLdapOptionalFeature.ps1
  • powershell/internal/services/ad/queries/Get-MtLdapPrinter.ps1
  • powershell/internal/services/ad/queries/Get-MtLdapReplicationSite.ps1
  • powershell/internal/services/ad/queries/Get-MtLdapSchemaObject.ps1
  • powershell/internal/services/ad/queries/Get-MtLdapServiceAccount.ps1
  • powershell/internal/services/ad/queries/Get-MtLdapUser.ps1
  • powershell/internal/services/ad/transport/Get-MtSysvolContent.ps1
  • powershell/public/services/ad/Get-MtADDomainState.ps1
  • powershell/public/services/ad/Get-MtADGpoState.ps1
  • powershell/tests/ad/transport/Get-MtSysvolContent.Tests.ps1
  • powershell/tests/functions/ADCertificateInventoryBatch.Tests.ps1
  • powershell/tests/functions/ADCollectorQueries.Tests.ps1
  • powershell/tests/functions/ADComputerChecks.Tests.ps1
  • powershell/tests/functions/ADConfigurationChecks.Tests.ps1
  • powershell/tests/functions/ADDaclConsolidation.Tests.ps1
  • powershell/tests/functions/ADDomainForestBatch.Tests.ps1
  • powershell/tests/functions/ADGpoInventory.Tests.ps1
  • powershell/tests/functions/ADGpoReports.Tests.ps1
  • powershell/tests/functions/ADGroupSpnChecks.Tests.ps1
  • powershell/tests/functions/ADGuideContent.Tests.ps1
  • powershell/tests/functions/ADPasswordPolicyBatch.Tests.ps1
  • powershell/tests/functions/ADResultPresentation.Tests.ps1
  • powershell/tests/functions/ADReviewCorrections.Tests.ps1
  • powershell/tests/functions/ADSchemaTrustChecks.Tests.ps1
  • powershell/tests/functions/ADSecondBatchCollectors.Tests.ps1
  • powershell/tests/functions/ADSiteOuBatch.Tests.ps1
  • powershell/tests/functions/ADUserSecurityBatch.Tests.ps1
  • powershell/tests/functions/ActiveDirectoryDacl.Tests.ps1
  • powershell/tests/functions/ActiveDirectoryGpoPermissions.Tests.ps1
  • powershell/tests/functions/ActiveDirectoryIssues.Tests.ps1
  • powershell/tests/functions/ActiveDirectoryOptIn.Tests.ps1
  • powershell/tests/functions/AdNtAuthCertificatePath.Tests.ps1
  • powershell/tests/functions/engine/Frameworks.Tests.ps1
  • powershell/tests/functions/golden/Golden.Tests.ps1
  • tests/ad/certificate-services/Test.AD-PKI-13.md
  • tests/ad/certificate-services/Test.AD-PKI-13.ps1
  • tests/ad/computer/Test.AD-COMP-01.md
  • tests/ad/computer/Test.AD-COMP-01.ps1
  • tests/ad/computer/Test.AD-COMP-02.md
  • tests/ad/computer/Test.AD-COMP-02.ps1
  • tests/ad/computer/Test.AD-COMP-03.md
  • tests/ad/computer/Test.AD-COMP-03.ps1
  • tests/ad/computer/Test.AD-COMP-04.md
  • tests/ad/computer/Test.AD-COMP-04.ps1
  • tests/ad/computer/Test.AD-COMP-05.md
  • tests/ad/computer/Test.AD-COMP-05.ps1
  • tests/ad/computer/Test.AD-COMP-06.md
  • tests/ad/computer/Test.AD-COMP-06.ps1
  • tests/ad/computer/Test.AD-COMP-07.md
  • tests/ad/computer/Test.AD-COMP-07.ps1
  • tests/ad/computer/Test.AD-COMP-08.md
  • tests/ad/computer/Test.AD-COMP-08.ps1
  • tests/ad/computer/Test.AD-COMP-09.md
  • tests/ad/computer/Test.AD-COMP-09.ps1
  • tests/ad/computer/Test.AD-COMP-10.md
  • tests/ad/computer/Test.AD-COMP-10.ps1
  • tests/ad/config/Test.AD-CFG-01.md
  • tests/ad/config/Test.AD-CFG-01.ps1
  • tests/ad/config/Test.AD-CFG-02.md
  • tests/ad/config/Test.AD-CFG-02.ps1
  • tests/ad/config/Test.AD-CFG-03.md
  • tests/ad/config/Test.AD-CFG-03.ps1
  • tests/ad/config/Test.AD-CFG-04.md
  • tests/ad/config/Test.AD-CFG-04.ps1
  • tests/ad/config/Test.AD-CFG-05.md
  • tests/ad/config/Test.AD-CFG-05.ps1
  • tests/ad/config/Test.AD-CFG-06.md
  • tests/ad/config/Test.AD-CFG-06.ps1
  • tests/ad/config/Test.AD-CFG-07.md
  • tests/ad/config/Test.AD-CFG-07.ps1
  • tests/ad/config/Test.AD-CFG-08.md
  • tests/ad/config/Test.AD-CFG-08.ps1
  • tests/ad/config/Test.AD-CFG-09.md
  • tests/ad/config/Test.AD-CFG-09.ps1
  • tests/ad/config/Test.AD-CFG-10.md
  • tests/ad/config/Test.AD-CFG-10.ps1
  • tests/ad/config/Test.AD-CFG-11.md
  • tests/ad/config/Test.AD-CFG-11.ps1
  • tests/ad/config/Test.AD-CFG-12.md
  • tests/ad/config/Test.AD-CFG-12.ps1
  • tests/ad/config/Test.AD-CFG-13.md
  • tests/ad/config/Test.AD-CFG-13.ps1
  • tests/ad/config/Test.AD-CFG-14.md
  • tests/ad/config/Test.AD-CFG-14.ps1
  • tests/ad/config/Test.AD-CFG-15.md
  • tests/ad/config/Test.AD-CFG-15.ps1
  • tests/ad/config/Test.AD-CFG-16.md
  • tests/ad/config/Test.AD-CFG-16.ps1
  • tests/ad/config/Test.AD-CFG-17.md
  • tests/ad/config/Test.AD-CFG-17.ps1
  • tests/ad/config/Test.AD-CFG-18.md
  • tests/ad/config/Test.AD-CFG-18.ps1
  • tests/ad/config/Test.AD-CFG-19.md
  • tests/ad/config/Test.AD-CFG-19.ps1
  • tests/ad/config/Test.AD-CFG-20.md
  • tests/ad/config/Test.AD-CFG-20.ps1
  • tests/ad/config/Test.AD-CFG-21.md
  • tests/ad/config/Test.AD-CFG-21.ps1
  • tests/ad/config/Test.AD-CFG-22.md
  • tests/ad/config/Test.AD-CFG-22.ps1
  • tests/ad/config/Test.AD-CFG-23.md
  • tests/ad/config/Test.AD-CFG-23.ps1
  • tests/ad/config/Test.AD-CFG-24.md
  • tests/ad/config/Test.AD-CFG-24.ps1
  • tests/ad/dacl/Test.AD-DACL-01.md
  • tests/ad/dacl/Test.AD-DACL-02.md
  • tests/ad/dacl/Test.AD-DACL-03.md
  • tests/ad/dacl/Test.AD-DACL-03.ps1
  • tests/ad/dacl/Test.AD-DACL-04.md
  • tests/ad/dacl/Test.AD-DACL-04.ps1
  • tests/ad/dacl/Test.AD-DACL-05.md
  • tests/ad/dacl/Test.AD-DACL-05.ps1
  • tests/ad/dacl/Test.AD-DACL-06.md
  • tests/ad/dacl/Test.AD-DACL-06.ps1
  • tests/ad/dacl/Test.AD-DACL-07.md
  • tests/ad/dacl/Test.AD-DACL-07.ps1
  • tests/ad/dacl/Test.AD-DACL-08.md
  • tests/ad/dacl/Test.AD-DACL-08.ps1
  • tests/ad/dacl/Test.AD-DACL-09.md
  • tests/ad/dacl/Test.AD-DACL-09.ps1
  • tests/ad/dacl/Test.AD-DACL-10.md
  • tests/ad/dacl/Test.AD-DACL-10.ps1
  • tests/ad/dacl/Test.AD-DACL-11.md
  • tests/ad/dacl/Test.AD-DACL-11.ps1
  • tests/ad/dacl/Test.AD-DACL-12.md
  • tests/ad/dacl/Test.AD-DACL-12.ps1
  • tests/ad/dacl/Test.AD-DACL-13.md
  • tests/ad/dacl/Test.AD-DACL-13.ps1
  • tests/ad/dacl/Test.AD-DACL-14.md
  • tests/ad/dacl/Test.AD-DACL-15.md
  • tests/ad/dacl/Test.AD-DACL-15.ps1
  • tests/ad/dacl/Test.AD-DACL-16.md
  • tests/ad/dacl/Test.AD-DACL-16.ps1
  • tests/ad/dacl/Test.AD-DACL-17.md
  • tests/ad/dacl/Test.AD-DACL-17.ps1
  • tests/ad/dacl/Test.AD-DACL-18.md
  • tests/ad/dacl/Test.AD-DACL-18.ps1
  • tests/ad/delegation/Test.AD-USER-05.md
  • tests/ad/delegation/Test.AD-USER-05.ps1
  • tests/ad/dns/Test.AD-DNS-01.md
  • tests/ad/dns/Test.AD-DNS-02.md
  • tests/ad/dns/Test.AD-DNS-03.md
  • tests/ad/dns/Test.AD-DNS-04.md
  • tests/ad/dns/Test.AD-DNS-05.md
  • tests/ad/dns/Test.AD-DNS-06.md
  • tests/ad/dns/Test.AD-DNS-07.md
  • tests/ad/dns/Test.AD-DNS-08.md
  • tests/ad/dns/Test.AD-DNS-09.md
  • tests/ad/dns/Test.AD-DNS-10.md
  • tests/ad/dns/Test.AD-DNS-11.md
  • tests/ad/dns/Test.AD-DNS-12.md
  • tests/ad/dns/Test.AD-DNS-14.md
  • tests/ad/dns/Test.AD-DNS-16.md
  • tests/ad/dns/Test.AD-DNS-18.md
  • tests/ad/dns/Test.AD-DNS-19.md
  • tests/ad/domain-controller/Test.AD-DC-01.md
  • tests/ad/domain-controller/Test.AD-DC-01.ps1
  • tests/ad/domain-controller/Test.AD-DC-02.md
  • tests/ad/domain-controller/Test.AD-DC-03.md
  • tests/ad/domain-controller/Test.AD-DC-04.md
  • tests/ad/domain-controller/Test.AD-DC-05.md
  • tests/ad/domain-controller/Test.AD-DC-05.ps1
  • tests/ad/domain-controller/Test.AD-DC-06.md
  • tests/ad/domain-controller/Test.AD-DC-06.ps1
  • tests/ad/domain-controller/Test.AD-DC-07.md
  • tests/ad/domain-controller/Test.AD-DC-07.ps1
  • tests/ad/domain-controller/Test.AD-DC-08.md
  • tests/ad/domain-controller/Test.AD-DC-08.ps1
  • tests/ad/domain-controller/Test.AD-DCD-01.md
  • tests/ad/domain-controller/Test.AD-DCD-01.ps1
  • tests/ad/domain-controller/Test.AD-DCD-02.md
  • tests/ad/domain-controller/Test.AD-DCD-02.ps1
  • tests/ad/domain-controller/Test.AD-DCD-03.md
  • tests/ad/domain-controller/Test.AD-DCD-03.ps1
  • tests/ad/domain-controller/Test.AD-DCD-04.md
  • tests/ad/domain-controller/Test.AD-DCD-04.ps1
  • tests/ad/domain/Test.AD-DOM-01.md
  • tests/ad/domain/Test.AD-DOM-01.ps1
  • tests/ad/domain/Test.AD-DOM-02.md
  • tests/ad/domain/Test.AD-DOM-02.ps1
  • tests/ad/domain/Test.AD-DOM-03.md
  • tests/ad/domain/Test.AD-DOM-03.ps1
  • tests/ad/domain/Test.AD-DOM-04.md
  • tests/ad/domain/Test.AD-DOM-04.ps1
  • tests/ad/domain/Test.AD-DOM-05.md
  • tests/ad/domain/Test.AD-DOM-05.ps1
  • tests/ad/domain/Test.AD-DOM-06.md
  • tests/ad/domain/Test.AD-DOM-06.ps1
  • tests/ad/domain/Test.AD-DOM-07.md
  • tests/ad/domain/Test.AD-DOM-07.ps1
  • tests/ad/domain/Test.AD-DOM-08.md
  • tests/ad/domain/Test.AD-DOM-08.ps1
  • tests/ad/domain/Test.AD-DOMS-01.md
  • tests/ad/domain/Test.AD-DOMS-01.ps1
  • tests/ad/domain/Test.AD-FOR-01.md
  • tests/ad/domain/Test.AD-FOR-01.ps1
  • tests/ad/domain/Test.AD-FOR-02.md
  • tests/ad/domain/Test.AD-FOR-02.ps1
  • tests/ad/domain/Test.AD-FOR-03.md
  • tests/ad/domain/Test.AD-FOR-03.ps1
  • tests/ad/domain/Test.AD-FOR-04.md
  • tests/ad/domain/Test.AD-FOR-04.ps1
  • tests/ad/domain/Test.AD-FORS-01.md
  • tests/ad/domain/Test.AD-FORS-01.ps1
  • tests/ad/domain/Test.AD-FORS-02.md
  • tests/ad/domain/Test.AD-FORS-02.ps1
  • tests/ad/domain/Test.AD-FORS-03.md
  • tests/ad/domain/Test.AD-FORS-03.ps1
  • tests/ad/domain/Test.AD-FORS-04.md
  • tests/ad/domain/Test.AD-FORS-04.ps1
  • tests/ad/gpo-state/Test.AD-GPOREP-01.md
  • tests/ad/gpo-state/Test.AD-GPOREP-01.ps1
  • tests/ad/gpo-state/Test.AD-GPOREP-02.md
  • tests/ad/gpo-state/Test.AD-GPOREP-02.ps1
  • tests/ad/gpo-state/Test.AD-GPOREP-03.md
  • tests/ad/gpo-state/Test.AD-GPOREP-03.ps1
  • tests/ad/gpo-state/Test.AD-GPOREP-04.md
  • tests/ad/gpo-state/Test.AD-GPOREP-04.ps1
  • tests/ad/gpo-state/Test.AD-GPOREP-05.md
  • tests/ad/gpo-state/Test.AD-GPOREP-06.md
  • tests/ad/gpo-state/Test.AD-GPOREP-07.md
  • tests/ad/gpo-state/Test.AD-GPOREP-07.ps1
  • tests/ad/gpo-state/Test.AD-GPOREP-08.md
  • tests/ad/gpo-state/Test.AD-GPOREP-08.ps1
  • tests/ad/gpo-state/Test.AD-GPOREP-09.md
  • tests/ad/gpo-state/Test.AD-GPOREP-10.md
  • tests/ad/gpo-state/Test.AD-GPOREP-10.ps1
  • tests/ad/gpo-state/Test.AD-GPOREP-11.md
  • tests/ad/gpo-state/Test.AD-GPOREP-11.ps1
  • tests/ad/gpo-state/Test.AD-GPOREP-12.md
  • tests/ad/gpo-state/Test.AD-GPOREP-12.ps1
  • tests/ad/gpo-state/Test.AD-GPOREP-13.md
  • tests/ad/gpo-state/Test.AD-GPOREP-13.ps1
  • tests/ad/gpo-state/Test.AD-GPOREP-14.md
  • tests/ad/gpo-state/Test.AD-GPOREP-15.md
  • tests/ad/gpo-state/Test.AD-GPOREP-15.ps1
  • tests/ad/gpo-state/Test.AD-GPOREP-16.md
  • tests/ad/gpo-state/Test.AD-GPOREP-16.ps1
  • tests/ad/gpo-state/Test.AD-GPOREP-17.md
  • tests/ad/gpo-state/Test.AD-GPOREP-17.ps1
  • tests/ad/gpo-state/Test.AD-GPOREP-18.md
  • tests/ad/gpo-state/Test.AD-GPOREP-18.ps1
  • tests/ad/gpo-state/Test.AD-GPOREP-19.md
  • tests/ad/gpo-state/Test.AD-GPOREP-19.ps1
  • tests/ad/gpo-state/Test.AD-GPOREP-20.md
  • tests/ad/gpo-state/Test.AD-GPOREP-20.ps1
  • tests/ad/gpo-state/Test.AD-GPOS-01.md
  • tests/ad/gpo-state/Test.AD-GPOS-02.md
  • tests/ad/gpo-state/Test.AD-GPOS-03.md
  • tests/ad/gpo-state/Test.AD-GPOS-04.md
  • tests/ad/gpo-state/Test.AD-GPOS-05.md
  • tests/ad/gpo-state/Test.AD-GPOS-06.md
  • tests/ad/gpo-state/Test.AD-GPOS-07.md
  • tests/ad/gpo-state/Test.AD-GPOS-08.md
  • tests/ad/gpo-state/Test.AD-GPOS-09.md
  • tests/ad/gpo/Test.AD-GPO-01.md
  • tests/ad/gpo/Test.AD-GPO-01.ps1
  • tests/ad/gpo/Test.AD-GPO-02.md
  • tests/ad/gpo/Test.AD-GPO-02.ps1
  • tests/ad/gpo/Test.AD-GPO-03.md
  • tests/ad/gpo/Test.AD-GPO-03.ps1
  • tests/ad/gpo/Test.AD-GPO-04.md
  • tests/ad/gpo/Test.AD-GPO-04.ps1
  • tests/ad/gpo/Test.AD-GPO-05.md
  • tests/ad/gpo/Test.AD-GPO-05.ps1
  • tests/ad/gpo/Test.AD-GPOL-01.md
  • tests/ad/gpo/Test.AD-GPOL-02.md
  • tests/ad/gpo/Test.AD-GPOL-02.ps1
  • tests/ad/gpo/Test.AD-GPOL-03.md
  • tests/ad/gpo/Test.AD-GPOL-03.ps1
  • tests/ad/gpo/Test.AD-GPOL-04.md
  • tests/ad/gpo/Test.AD-GPOL-04.ps1
  • tests/ad/gpo/Test.AD-GPOL-05.md
  • tests/ad/gpo/Test.AD-GPOL-05.ps1
  • tests/ad/gpo/Test.AD-GPOL-06.md
  • tests/ad/gpo/Test.AD-GPOL-06.ps1
  • tests/ad/group/Test.AD-GCHG-01.md
  • tests/ad/group/Test.AD-GMC-01.md
  • tests/ad/group/Test.AD-GMC-01.ps1
  • tests/ad/group/Test.AD-GMC-02.md
  • tests/ad/group/Test.AD-GMC-02.ps1
  • tests/ad/group/Test.AD-GMC-03.md
  • tests/ad/group/Test.AD-GMC-03.ps1
  • tests/ad/group/Test.AD-GMC-04.md
  • tests/ad/group/Test.AD-GMC-04.ps1
  • tests/ad/group/Test.AD-GMC-05.md
  • tests/ad/group/Test.AD-GMC-05.ps1
  • tests/ad/group/Test.AD-GMC-06.md
  • tests/ad/group/Test.AD-GMC-06.ps1
  • tests/ad/group/Test.AD-GMC-07.md
  • tests/ad/group/Test.AD-GMC-07.ps1
  • tests/ad/group/Test.AD-GMC-08.md
  • tests/ad/group/Test.AD-GMC-08.ps1
  • tests/ad/group/Test.AD-GMC-09.md
  • tests/ad/group/Test.AD-GMC-09.ps1
  • tests/ad/group/Test.AD-GMC-10.md
  • tests/ad/group/Test.AD-GMC-10.ps1
  • tests/ad/group/Test.AD-GMC-11.md
  • tests/ad/group/Test.AD-GMC-11.ps1
  • tests/ad/group/Test.AD-GRP-01.md
  • tests/ad/group/Test.AD-GRP-01.ps1
  • tests/ad/group/Test.AD-GRP-02.md
  • tests/ad/group/Test.AD-GRP-02.ps1
  • tests/ad/group/Test.AD-GRP-03.md
  • tests/ad/group/Test.AD-GRP-03.ps1
  • tests/ad/group/Test.AD-GRP-04.md
  • tests/ad/group/Test.AD-GRP-04.ps1
  • tests/ad/group/Test.AD-GRP-05.md
  • tests/ad/group/Test.AD-GRP-05.ps1
  • tests/ad/group/Test.AD-GRP-06.md
  • tests/ad/group/Test.AD-GRP-06.ps1
  • tests/ad/group/Test.AD-GRP-07.md
  • tests/ad/group/Test.AD-GRP-07.ps1
  • tests/ad/group/Test.AD-GRP-08.md
  • tests/ad/group/Test.AD-GRP-08.ps1
  • tests/ad/group/Test.AD-GRP-09.md
  • tests/ad/group/Test.AD-GRP-09.ps1
  • tests/ad/group/Test.AD-GRP-10.md
  • tests/ad/group/Test.AD-GRP-10.ps1
  • tests/ad/ou/Test.AD-OU-01.md
  • tests/ad/ou/Test.AD-OU-01.ps1
  • tests/ad/ou/Test.AD-OU-02.md
  • tests/ad/ou/Test.AD-OU-02.ps1
  • tests/ad/ou/Test.AD-OU-03.md
  • tests/ad/ou/Test.AD-OU-03.ps1
  • tests/ad/ou/Test.AD-OU-04.md
  • tests/ad/ou/Test.AD-OU-04.ps1
  • tests/ad/ou/Test.AD-OU-05.md
  • tests/ad/ou/Test.AD-OU-05.ps1
  • tests/ad/password-policy/Test.AD-FGPP-01.md
  • tests/ad/password-policy/Test.AD-FGPP-01.ps1
  • tests/ad/password-policy/Test.AD-FGPP-02.md
  • tests/ad/password-policy/Test.AD-FGPP-02.ps1
  • tests/ad/password-policy/Test.AD-FGPP-03.md
  • tests/ad/password-policy/Test.AD-FGPP-03.ps1
  • tests/ad/password-policy/Test.AD-FGPP-04.md
  • tests/ad/password-policy/Test.AD-FGPP-04.ps1
  • tests/ad/password-policy/Test.AD-PWDPOL-01.md
  • tests/ad/password-policy/Test.AD-PWDPOL-01.ps1
  • tests/ad/password-policy/Test.AD-PWDPOL-02.md
  • tests/ad/password-policy/Test.AD-PWDPOL-02.ps1
  • tests/ad/password-policy/Test.AD-PWDPOL-03.md
  • tests/ad/password-policy/Test.AD-PWDPOL-03.ps1
  • tests/ad/password-policy/Test.AD-PWDPOL-04.md
  • tests/ad/password-policy/Test.AD-PWDPOL-04.ps1
  • tests/ad/password-policy/Test.AD-PWDPOL-05.md
  • tests/ad/password-policy/Test.AD-PWDPOL-05.ps1
  • tests/ad/password-policy/Test.AD-PWDPOL-06.md
  • tests/ad/password-policy/Test.AD-PWDPOL-06.ps1
  • tests/ad/password-policy/Test.AD-PWDPOL-07.md
  • tests/ad/password-policy/Test.AD-PWDPOL-07.ps1
  • tests/ad/printer/Test.AD-PRINT-01.md
  • tests/ad/printer/Test.AD-PRINT-01.ps1
  • tests/ad/replication/Test.AD-DFSR-01.md
  • tests/ad/replication/Test.AD-FEAT-01.md
  • tests/ad/replication/Test.AD-FEAT-01.ps1
  • tests/ad/replication/Test.AD-FEAT-02.md
  • tests/ad/replication/Test.AD-FEAT-02.ps1
  • tests/ad/replication/Test.AD-REPL-01.md
  • tests/ad/replication/Test.AD-REPL-02.md
  • tests/ad/replication/Test.AD-ROOTDSE-01.md
  • tests/ad/replication/Test.AD-ROOTDSE-01.ps1
  • tests/ad/replication/Test.AD-ROOTDSE-02.md
  • tests/ad/replication/Test.AD-ROOTDSE-02.ps1
  • tests/ad/replication/Test.AD-ROOTDSE-03.md
  • tests/ad/schema/Test.AD-SCH-01.md
  • tests/ad/schema/Test.AD-SCH-01.ps1
  • tests/ad/schema/Test.AD-SCH-02.md
  • tests/ad/schema/Test.AD-SCH-02.ps1
  • tests/ad/schema/Test.AD-SCH-03.md
  • tests/ad/schema/Test.AD-SCH-03.ps1
  • tests/ad/schema/Test.AD-SCH-04.md
  • tests/ad/schema/Test.AD-SCH-04.ps1
  • tests/ad/schema/Test.AD-SCH-05.md
  • tests/ad/schema/Test.AD-SCH-05.ps1
  • tests/ad/security/Test.AD-DCOMP-01.md
  • tests/ad/security/Test.AD-DCOMP-01.ps1
  • tests/ad/security/Test.AD-DCOMP-02.md
  • tests/ad/security/Test.AD-DCOMP-02.ps1
  • tests/ad/security/Test.AD-DCOMP-03.md
  • tests/ad/security/Test.AD-DCOMP-03.ps1
  • tests/ad/security/Test.AD-DCOMP-04.md
  • tests/ad/security/Test.AD-DCOMP-04.ps1
  • tests/ad/security/Test.AD-DCOMP-05.md
  • tests/ad/security/Test.AD-DCOMP-05.ps1
  • tests/ad/security/Test.AD-DCOMP-06.md
  • tests/ad/security/Test.AD-DCOMP-06.ps1
  • tests/ad/security/Test.AD-DCOMP-07.md
  • tests/ad/security/Test.AD-DCOMP-07.ps1
  • tests/ad/security/Test.AD-DCOMP-08.md
  • tests/ad/security/Test.AD-DCOMP-08.ps1
  • tests/ad/security/Test.AD-DCOMP-09.md
  • tests/ad/security/Test.AD-DCOMP-09.ps1
  • tests/ad/security/Test.AD-KRBTGT-01.md
  • tests/ad/security/Test.AD-KRBTGT-01.ps1
  • tests/ad/security/Test.AD-KRBTGT-02.md
  • tests/ad/security/Test.AD-KRBTGT-03.md
  • tests/ad/security/Test.AD-MSA-01.md
  • tests/ad/security/Test.AD-MSA-01.ps1
  • tests/ad/site/Test.AD-SITE-01.md
  • tests/ad/site/Test.AD-SITE-01.ps1
  • tests/ad/site/Test.AD-SITE-02.md
  • tests/ad/site/Test.AD-SITE-02.ps1
  • tests/ad/site/Test.AD-SITE-03.md
  • tests/ad/site/Test.AD-SITE-03.ps1
  • tests/ad/site/Test.AD-SITE-04.md
  • tests/ad/site/Test.AD-SITE-04.ps1
  • tests/ad/site/Test.AD-SITE-05.md
  • tests/ad/site/Test.AD-SITE-05.ps1
  • tests/ad/site/Test.AD-SUB-01.md
  • tests/ad/site/Test.AD-SUB-01.ps1
  • tests/ad/site/Test.AD-SUB-02.md
  • tests/ad/site/Test.AD-SUB-02.ps1
  • tests/ad/site/Test.AD-SUB-03.md
  • tests/ad/site/Test.AD-SUB-03.ps1
  • tests/ad/site/Test.AD-SUB-04.md
  • tests/ad/site/Test.AD-SUB-04.ps1
  • tests/ad/site/Test.AD-SUB-05.md
  • tests/ad/site/Test.AD-SUB-05.ps1
  • tests/ad/site/Test.AD-SUB-06.md
  • tests/ad/site/Test.AD-SUB-06.ps1
  • tests/ad/site/Test.AD-SUB-07.md
  • tests/ad/site/Test.AD-SUB-07.ps1
  • tests/ad/site/Test.AD-SUB-08.md
  • tests/ad/site/Test.AD-SUB-08.ps1
  • tests/ad/site/Test.AD-SUB-09.md
  • tests/ad/site/Test.AD-SUB-09.ps1
  • tests/ad/site/Test.AD-SUB-10.md
  • tests/ad/site/Test.AD-SUB-10.ps1
  • tests/ad/site/Test.AD-SUB-11.md
  • tests/ad/site/Test.AD-SUB-11.ps1
  • tests/ad/spn/Test.AD-SPN-01.md
  • tests/ad/spn/Test.AD-SPN-01.ps1
  • tests/ad/spn/Test.AD-SPN-02.md
  • tests/ad/spn/Test.AD-SPN-02.ps1
  • tests/ad/spn/Test.AD-SPN-03.md
  • tests/ad/spn/Test.AD-SPN-03.ps1
  • tests/ad/spn/Test.AD-SPN-04.md
  • tests/ad/spn/Test.AD-SPN-04.ps1
  • tests/ad/spn/Test.AD-SPN-05.md
  • tests/ad/spn/Test.AD-SPN-05.ps1
  • tests/ad/spn/Test.AD-SPN-06.md
  • tests/ad/spn/Test.AD-SPN-06.ps1
  • tests/ad/spn/Test.AD-SPN-07.md
  • tests/ad/spn/Test.AD-SPN-07.ps1
  • tests/ad/spn/Test.AD-SPN-08.md
  • tests/ad/spn/Test.AD-SPN-08.ps1
  • tests/ad/spn/Test.AD-SPN-09.md
  • tests/ad/spn/Test.AD-SPN-09.ps1
  • tests/ad/spn/Test.AD-SPN-10.md
  • tests/ad/spn/Test.AD-SPN-10.ps1
  • tests/ad/spn/Test.AD-SPN-11.md
  • tests/ad/spn/Test.AD-SPN-11.ps1
  • tests/ad/spn/Test.AD-SPN-12.md
  • tests/ad/spn/Test.AD-SPN-12.ps1
  • tests/ad/spn/Test.AD-SPN-13.md
  • tests/ad/spn/Test.AD-SPN-13.ps1
  • tests/ad/trust/Test.AD-TRUST-01.md
  • tests/ad/trust/Test.AD-TRUST-01.ps1
  • tests/ad/trust/Test.AD-TRUST-02.md
  • tests/ad/trust/Test.AD-TRUST-02.ps1
  • tests/ad/trust/Test.AD-TRUST-03.md
  • tests/ad/trust/Test.AD-TRUST-03.ps1
  • tests/ad/trust/Test.AD-TRUST-04.md
  • tests/ad/trust/Test.AD-TRUST-04.ps1
  • tests/ad/trust/Test.AD-TRUST-05.md
  • tests/ad/trust/Test.AD-TRUST-05.ps1
  • tests/ad/trust/Test.AD-TRUST-06.md
  • tests/ad/trust/Test.AD-TRUST-06.ps1
  • tests/ad/trust/Test.AD-TRUST-07.md
  • tests/ad/trust/Test.AD-TRUST-07.ps1
  • tests/ad/user/Test.AD-USER-01.md
  • tests/ad/user/Test.AD-USER-01.ps1
  • tests/ad/user/Test.AD-USER-02.md
  • tests/ad/user/Test.AD-USER-02.ps1
  • tests/ad/user/Test.AD-USER-03.md
  • tests/ad/user/Test.AD-USER-03.ps1
  • tests/ad/user/Test.AD-USER-04.md
  • tests/ad/user/Test.AD-USER-04.ps1
  • tests/ad/user/Test.AD-USER-05.md
  • tests/ad/user/Test.AD-USER-05.ps1
  • tests/ad/user/Test.AD-USER-06.md
  • tests/ad/user/Test.AD-USER-06.ps1
  • tests/ad/user/Test.AD-USER-07.md
  • tests/ad/user/Test.AD-USER-07.ps1
  • tests/ad/user/Test.AD-USER-08.md
  • tests/ad/user/Test.AD-USER-08.ps1
  • tests/ad/user/Test.AD-USER-09.md
  • tests/ad/user/Test.AD-USER-09.ps1
  • tests/ad/user/Test.AD-USER-10.md
  • tests/ad/user/Test.AD-USER-10.ps1
  • tests/ad/user/Test.AD-USER-11.md
  • tests/ad/user/Test.AD-USER-11.ps1
  • tests/ad/user/Test.AD-USER-12.md
  • tests/ad/user/Test.AD-USER-12.ps1
  • tests/ad/user/Test.AD-USER-13.md
  • tests/ad/user/Test.AD-USER-13.ps1
  • tests/ad/user/Test.AD-USER-14.md
  • tests/ad/user/Test.AD-USER-14.ps1
  • tests/ad/user/Test.AD-USER-15.md
  • tests/ad/user/Test.AD-USER-15.ps1
  • tests/ad/user/Test.AD-USER-16.md
  • tests/ad/user/Test.AD-USER-16.ps1
  • tests/ad/user/Test.AD-USER-17.md
  • tests/ad/user/Test.AD-USER-17.ps1
  • tests/ad/user/Test.AD-USER-18.md
  • tests/ad/user/Test.AD-USER-18.ps1
  • tests/ad/user/Test.AD-USER-19.md
  • tests/ad/user/Test.AD-USER-19.ps1
  • tests/ad/user/Test.AD-USER-20.md
  • tests/ad/user/Test.AD-USER-20.ps1
  • tests/ad/user/Test.AD-USER-21.md
  • tests/ad/user/Test.AD-USER-21.ps1
  • tests/ad/user/Test.AD-USER-22.md
  • tests/ad/user/Test.AD-USER-22.ps1
  • tests/ad/user/Test.AD-USER-23.md
  • tests/ad/user/Test.AD-USER-23.ps1
  • tests/ad/user/Test.AD-USER-24.md
  • tests/ad/user/Test.AD-USER-24.ps1
  • tests/ad/user/Test.AD-USER-25.md
  • tests/ad/user/Test.AD-USER-25.ps1
  • tests/ad/user/Test.AD-USER-26.md
  • tests/ad/user/Test.AD-USER-26.ps1
  • tests/ad/user/Test.AD-USER-27.md
  • tests/ad/user/Test.AD-USER-27.ps1
  • tests/ad/user/Test.AD-USER-28.md
  • tests/ad/user/Test.AD-USER-28.ps1
  • tests/ad/user/Test.AD-USER-29.md
  • tests/ad/user/Test.AD-USER-29.ps1
  • website/docs/advanced/active-directory.md
  • website/docs/upgrading-from-2x.md
  • website/scripts/test-retired-test-redirects.mjs
  • website/src/lib/redirects.mjs

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

Copy link
Copy Markdown
Contributor

Attribute review

Attribute review: 50 tests need review, more than the limit of 25 for one run. Split the change, or ask a maintainer to review the attributes and apply the attribute-review-override label.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@FiraSenax
FiraSenax marked this pull request as ready for review November 14, 2026 17:37
@FiraSenax
FiraSenax requested review from a team as code owners November 14, 2026 17:37
@FiraSenax FiraSenax mentioned this pull request Nov 15, 2026
5 of 7 tasks

@earbona23 earbona23 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check itself reads well — CustomRootTrust with DisableCertificateDownloads, revocation explicitly off and recorded as off in the output, every X509Certificate2 and X509Chain disposed in a finally, and PathUsesCertificateOutsidePublishedInventory to catch a path that leans on something the inventory never published. Offline is the right call for this, and the result says plainly what it does not assess.

Two things before it can be read, though, and the first is why I started here rather than in the diff.

This pull request carries #2734

GitHub shows 567 files and -18,692 lines against main. Measured locally, almost none of that is yours:

git merge-base --is-ancestor <soulemike/ad-test-consolidation> <codex/ntauth-certificate-chain>
  -> true, so this branch contains #2734's commits

git diff --stat <soulemike/ad-test-consolidation> <codex/ntauth-certificate-chain>
  -> 5 files changed, 494 insertions(+), 2 deletions(-)

git rev-list --count <soulemike/ad-test-consolidation>..<codex/ntauth-certificate-chain>
  -> 3

Your own work is three commits over five files:

File
powershell/internal/services/ad/Get-MtAdNtAuthCertificatePath.ps1 +122
powershell/tests/functions/AdNtAuthCertificatePath.Tests.ps1 +281
tests/ad/certificate-services/Test.AD-PKI-13.ps1 +55
tests/ad/certificate-services/Test.AD-PKI-13.md +27
powershell/internal/checks/ad/ad/Get-MtAdCertificateInventory.ps1 +9/-2

The other 562 are @soulemike's AD test consolidation, still open as #2734. Both branches delete the same 182 files under tests/ad/, and all 182 are still present on main, so as it stands this pull request would take the consolidation in under a title about NTAuth paths, and whichever lands first makes the other conflict — which is already why this one shows CONFLICTING.

Rebasing those three commits onto current main would turn this into a five-file review, and it would stop the consolidation being merged twice or reviewed in the wrong thread. If the dependency is real and Get-MtAdCertificateInventory -IncludeRawData only exists after #2734, then retargeting the base at that branch says so explicitly instead of hiding it.

-SkippedCustomReason is dropped here

Test.AD-PKI-13.ps1:

Add-MtTestResultDetail -SkippedBecause NotApplicable -SkippedCustomReason 'The collected NTAuth store contains no CA certificates.'

Add-MtTestResultDetail only reads -SkippedCustomReason when -SkippedBecause is Custom (powershell/public/run/Add-MtTestResultDetail.ps1:123-127); every other value takes the else branch and overwrites the reason with Get-MtSkippedReason $SkippedBecause. So that sentence never reaches the operator and the report shows the generic not-applicable text. Nothing else in the repository combines those two — -SkippedBecause Custom appears in 207 places and that is the form that keeps the message.

-SkippedBecause Custom -SkippedCustomReason '...' is what you want, and the empty store deserves the specific wording: it is the difference between "this does not apply to you" and "the store I read was empty".

One question

There is no return after that skip. It does terminate — the helper throws a skip record under the native engine and calls Set-ItResult -Skipped under Pester — so I do not think it is live, but the block below it builds a table over an empty $paths and calls Add-MtTestResultDetail a second time, so a reader has to go and check the helper to know it is unreachable. An explicit return would make it local.

And on the subordinate-CA count: the loop increments after comparing, walking ChainElements from leaf to root, and your comment says this is deliberate because Build treats the target as an end entity. That is the kind of off-by-one that is right until it is not — is there a case in the 281 lines of tests with a three-level path and pathLenConstraint = 0 on the root, where the engine's own InvalidBasicConstraints and your counter should agree?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants