Repository navigation
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
3 tasks
izikaj
marked this pull request as ready for review
November 9, 2026 15:41
izikaj
requested review from
IgorDobryn,
Ma-Anna,
Rabsztok,
mklocek and
oshchyhol
November 9, 2026 15:42
IgorDobryn
approved these changes
Nov 10, 2026
IgorDobryn
left a comment
Contributor
There was a problem hiding this comment.
specs/email-campaigns.openapi.yml:1862
getMarketingStats still says Email API/SMTP traffic is not included. Here it names the product, not a protocol, so under the new naming guide it should be renamed too. That also matches the "Email Marketing" set already used in this paragraph:
Overview in the app for the same filters. Email Live Sending traffic is not included;If you'd rather keep this PR an exact revert of #67, please open a follow-up that merges in the same window. Otherwise the docs will mix both names after the switch.
mklocek
approved these changes
Nov 10, 2026
The Stats tag in email-sending.openapi.yml and getMarketingStats in email-campaigns.openapi.yml named the product with the old name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
GitBook shows x-page-description as the page subtitle, directly above the renamed tag description. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This applies the rename from #64 again. #67 rolled it back because the app did not show the new product name yet.
Merge this PR when the app shows "Email Live Sending", not before. The spec goes live on docs.mailtrap.io as soon as it merges. Merge it together with mailtrap/mailtrap-docs#14.
The first commit is a revert of #67. The later commits rename three mentions that #64 did not change.
Changes
The same changes as #64:
account-management.openapi.yml, "Get current billing cycle usage": the description and the200response say "Email Live Sending" and "Email Sandbox".inbound.openapi.yml: the sharedForbiddenresponse says "Email Live Sending is not enabled". The "Email API" mentions in the message, reply and forward schemas say "Email Live Sending".email-sending.openapi.yml: the spec title is "Email Live Sending".README.md: the spec rows say "Live Sending".CLAUDE.md: the naming guide uses "Email Live Sending" and lists the old names.Added after review:
email-sending.openapi.yml: the Stats tag description says "Email Live Sending aggregated stats". The Stats page subtitle (x-page-description) says "Email Live Sending stats".email-campaigns.openapi.yml, "Get Email Marketing stats": "Email Live Sending traffic is not included".How to test
git diff a769359 HEADon this branch shows only the three lines added after review403response on an inbound page says "Email Live Sending is not enabled for the organization"spectral lint "specs/*.openapi.yml"reports no errors