Repository navigation
Conversation
Changed Files
|
Contributor
|
| Project | Bevy Scripting |
| Branch | agent/reactive-ui-each |
| Testbed | linux-gha |
⚠️ WARNING: Truncated view!The full continuous benchmarking report exceeds the maximum length allowed on this platform.
🐰 View full continuous benchmarking report in Bencher
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
# Conflicts: # assets/benchmarks/reactive_ui/closures.lua # assets/benchmarks/reactive_ui/paths.lua # assets/tests/reactive_ui/inventory/inventory.lua # crates/bevy_mod_scripting_reactive_ui/src/lib.rs
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ui.each(items, function(item) .. end): a region with one child per item of the list held by a signal. Children are kept by item (the item is the key, askeyis forui.el), so the function only runs for items which were not in the list before. Aui.dynamiclist re-runs the whole loop on every change: oneui.elcall and props conversion per row, kept or not.ui.dynamicdoes.ui.dynamicstays covered by the other regions.inventory add or remove one.Stacked on #719.
Measured on a local merge with #720 and #721, prebuilt binaries, 3 alternating rounds (Closures):
ui.dynamicui.eachIt only helps when most rows stay. What is left of the one row case is the list of 200 names itself: it crosses to Rust when computed, back to Lua for the title, and is keyed in Rust.