Repository navigation
Conversation
Changed Files
|
Contributor
|
| Project | Bevy Scripting |
| Branch | agent/reactive-ui-events |
| Testbed | linux-gha |
⚠️ WARNING: Truncated view!The full continuous benchmarking report exceeds the maximum length allowed on this platform.
🐰 View full continuous benchmarking report in Bencher
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Contributor
|
| Project | Bevy Scripting |
| Branch | agent/reactive-ui-events |
| Testbed | linux-gha |
⚠️ WARNING: Truncated view!The full continuous benchmarking report exceeds the maximum length allowed on this platform.
🐰 View full continuous benchmarking report in Bencher
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elements handle
bevy_picking's pointer events, instead of polling the deprecatedInteractioncomponent.events.rs) queues the handler of the entity the event is at. Handlers run in the next flush, in their script's context, as before{ x, y, button, count, delta_x, delta_y }as the event has themui.interact(entity, "click")does what a pointer event on the element would, for tests and for driving a ui without a pointer (it takes the event names now:"press"ison_press)Rune checks argument counts, so its handlers declare the event:
|selected, name, _event| ...Not covered by a test: the observers themselves (the tests go through
ui.interact), there is no pointer in the headless test app.Stacked on #728.