Repository navigation
Conversation
|
Review changes with Changed Files
|
Contributor
|
Bencher Report| Project | Bevy Scripting |
| Branch | agent/reactive-ui-scroll |
| Testbed | linux-gha |
⚠️ WARNING: Truncated view!The full continuous benchmarking report exceeds the maximum length allowed on this platform.
🐰 View full continuous benchmarking report in Bencher
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
- `ui.render` roots were auto-sized: bevy_ui wraps root nodes in an implicit grid with an auto track, so `height = "100%"` in a script was of the content and nothing overflowed to scroll. Roots are now 100vw x 100vh and ignore picking. - The test harness initialises image assets (the reactive ui no longer does, since bc800c8). - Example: restyled, cards fill the width, hover states, Rust eases each item's stock bar and flashes restocked items (rows bind to the fields, only moving rows update).
# Conflicts: # crates/testing_crates/script_integration_test_harness/src/lib.rs
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft: not verified with a real mouse wheel, there is no pointer in this environment.
An element whose
overflowis"scroll"on an axis scrolls with the mouse wheel: an observer ofPointerScrollmoves theScrollPositionof the innermost such element under the pointer, no script code involved.on_scrollhandlers still get the event.The example's inventory uses it.
This is the scroll half of "scroll and text input". Not done:
bevy_ui0.20 has text input layout andbevy_input_focus, wiring them to signals is its own piece of workStacked on #731.