Repository navigation
feat: add opt-in full-point rendering with checkExactPoints - #107
Merged
Merged
Conversation
camchis
changed the title
checkExactPoints prop)
chrispader
changed the title
checkExactPoints prop)
chrispader
approved these changes
Oct 13, 2026
chrispader
left a comment
chrispader
left a comment
Member
There was a problem hiding this comment.
After a looong time, finally merging this. Thanks @camchis !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pixel sampling can skip values in dense data or when timestamps are unevenly spaced. This PR adds
checkExactPoints, which defaults totrueto preserve existing behavior. Set it tofalseto use every point at its date-derived horizontal position in both static and animated graphs. Scrubbing in this mode selects the point with the nearest timestamp.The example includes a "Draw every point" toggle. Using every point creates larger paths for large datasets.
Reproduction
Pass points with timestamps
0,9, and10and values0,100, and0. SetcheckExactPoints={false}to include the middle value near the right edge. Toggle the prop on an animated graph, including one with a gradient, and confirm the path updates without replacing the points.