Repository navigation
build: publish built JavaScript so apps don't compile the specs - #457
Open
chrispader wants to merge 1 commit into
Open
chrispader wants to merge 1 commit into
chrispader wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
chrispader
added this pull request to stack #461
October 22, 2026 18:19
chrispader
force-pushed
the
nitro-v1/built-entry-points
branch
from
October 22, 2026 18:44
0583ba8 to
2fabba9
Compare
chrispader
removed this pull request from stack #461
October 22, 2026 20:15
chrispader
force-pushed
the
nitro-v1/built-entry-points
branch
from
October 22, 2026 20:15
2fabba9 to
27e6430
Compare
chrispader
added this pull request to stack #464
October 22, 2026 20:16
The package's react-native and source fields pointed at src, so apps compiled the decorated .nitro.ts specs with their own Babel config, which React Native's default preset can't parse. The entry points now point at lib, and bob parses the specs through per-target Babel configs. main points at the CommonJS build that bob validates it against, and CI builds the package so a broken build shows up before a release. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
chrispader
removed this pull request from stack #464
October 23, 2026 00:18
chrispader
force-pushed
the
nitro-v1/built-entry-points
branch
from
October 23, 2026 00:19
27e6430 to
57bff2d
Compare
chrispader
added this pull request to stack #466
October 23, 2026 00:19
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Nitro V1 specs use decorators, which React Native's default Babel preset can't parse. The package's
react-nativeandsourcefields pointed atsrc, so every app would compile the specs with its own Babel config and fail. bob couldn't build the package for the same reason, so the next release would have failed to publish.The entry points now point at the built output, and bob parses the specs through a small Babel config for each JavaScript target.
mainpoints at the CommonJS build that bob checks it against, and CI builds the package.Reproduction
Run the package's
buildscript inpackages/react-native-nitro-sqlite. Before this change, bob stops with "Support for the experimental syntax 'decorators' isn't currently enabled".🤖 Generated with Claude Code