Repository navigation
feat: only comments may follow a concise ; line's html comment - #263
Merged
DylanPiercey merged 1 commit intoNov 2, 2026
Merged
Conversation
After a `;` ends a concise line, code after an html comment was read as a new line indented under the tag (`div; <!-- a --> span` nested `span` in `div`). Only comments may follow the html comment now, as after the `;`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: c981357 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #263 +/- ##
=======================================
Coverage 99.89% 99.89%
=======================================
Files 35 35
Lines 4753 4758 +5
Branches 920 921 +1
=======================================
+ Hits 4748 4753 +5
Misses 4 4
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a
;ends a concise line (div;, or a line that is just;), an html comment returned to concise content, which read the rest of the line as a new line indented under the tag:div; <!-- a --> spannestedspaninsidedivinstead of reporting an error, unlike code after a/* */there. Now only comments may follow the html comment, as after the;itself, so code after it reportsINVALID_CODE_AFTER_SEMICOLON. A run of comments (div; <!-- a --> <!-- b --> // c) still parses as before.This matches the Marko tree-sitter grammar, which already treated it as an error.
🤖 Generated with Claude Code