Skip to content

feat: only comments may follow a concise ; line's html comment - #263

Merged
DylanPiercey merged 1 commit into
mainfrom
dpiercey-ws-typescript-7-janf0a-semicolon-html-comment
Nov 2, 2026
Merged

DylanPiercey merged 1 commit into
mainfrom
dpiercey-ws-typescript-7-janf0a-semicolon-html-comment

Conversation

@DylanPiercey

Copy link
Copy Markdown
Contributor

After a ; ends a concise line (div;, or a line that is just ;), an html comment returned to concise content, which read the rest of the line as a new line indented under the tag: div; <!-- a --> span nested span inside div instead of reporting an error, unlike code after a /* */ there. Now only comments may follow the html comment, as after the ; itself, so code after it reports INVALID_CODE_AFTER_SEMICOLON. A run of comments (div; <!-- a --> <!-- b --> // c) still parses as before.

This matches the Marko tree-sitter grammar, which already treated it as an error.

🤖 Generated with Claude Code

After a `;` ends a concise line, code after an html comment was read as a
new line indented under the tag (`div; <!-- a --> span` nested `span` in
`div`). Only comments may follow the html comment now, as after the `;`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Nov 2, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c981357

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
htmljs-parser Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DylanPiercey
DylanPiercey merged commit f48774c into main Nov 2, 2026
8 of 9 checks passed
@codecov

codecov Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.89%. Comparing base (b6a1e49) to head (c981357).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #263   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files          35       35           
  Lines        4753     4758    +5     
  Branches      920      921    +1     
=======================================
+ Hits         4748     4753    +5     
  Misses          4        4           
  Partials        1        1           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot mentioned this pull request Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant